Convert gamepad events to native methods

RESOLVED FIXED in Firefox 51

Status

()

P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jchen, Assigned: jchen)

Tracking

(Blocks: 1 bug)

unspecified
mozilla51
All
Android
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(4 attachments)

(Assignee)

Description

2 years ago
Convert the gamepad events in GeckoEvent to native method calls in AndroidGamepadManager, and also move gamepad-related methods in GeckoAppShell to AndroidGamepadManager.
(Assignee)

Comment 1

2 years ago
Created attachment 8775195 [details] [diff] [review]
Move gamepad methods out of GeckoAppShell (v1)

Move gamepad methods called by native code out of GeckoAppShell and into
AndroidGamepadManager.
Attachment #8775195 - Flags: review?(snorp)
(Assignee)

Comment 2

2 years ago
Created attachment 8775196 [details] [diff] [review]
Add native methods to AndroidGamepadManager (v1)

Add native method calls to AndroidGamepadManager to replace the gamepad
events in GeckoEvent. Implement those calls in AndroidGamepad.cpp. The
jni/Refs.h change is necessary to fix a compile error when using
jni::BooleanArray.
Attachment #8775196 - Flags: review?(snorp)
(Assignee)

Comment 3

2 years ago
Created attachment 8775197 [details] [diff] [review]
Updated auto-generated bindings (v1)
Attachment #8775197 - Flags: review+
(Assignee)

Comment 4

2 years ago
Created attachment 8775198 [details] [diff] [review]
Remove gamepad events from GeckoEvent (v1)

Remove the now-obsolete gamepad events from GeckoEvent, along with a few
other used fields in GeckoEvent.
Attachment #8775198 - Flags: review?(snorp)
Attachment #8775195 - Flags: review?(snorp) → review+
Attachment #8775196 - Flags: review?(snorp) → review+
Attachment #8775198 - Flags: review?(snorp) → review+
Priority: -- → P3

Comment 5

2 years ago
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/10231cdd4c76
Move gamepad methods out of GeckoAppShell; r=snorp
https://hg.mozilla.org/integration/fx-team/rev/c016f9d74449
Add native methods to AndroidGamepadManager; r=snorp
https://hg.mozilla.org/integration/fx-team/rev/86b4155ce94b
Updated auto-generated bindings; r=me
https://hg.mozilla.org/integration/fx-team/rev/40578d56c4ff
Remove gamepad events from GeckoEvent; r=snorp

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/10231cdd4c76
https://hg.mozilla.org/mozilla-central/rev/c016f9d74449
https://hg.mozilla.org/mozilla-central/rev/86b4155ce94b
https://hg.mozilla.org/mozilla-central/rev/40578d56c4ff
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.