Closed Bug 1289208 Opened 8 years ago Closed 8 years ago

Convert gamepad events to native methods

Categories

(Core Graveyard :: Widget: Android, defect, P3)

All
Android
defect

Tracking

(firefox51 fixed)

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

Details

Attachments

(4 files)

Convert the gamepad events in GeckoEvent to native method calls in AndroidGamepadManager, and also move gamepad-related methods in GeckoAppShell to AndroidGamepadManager.
Move gamepad methods called by native code out of GeckoAppShell and into
AndroidGamepadManager.
Attachment #8775195 - Flags: review?(snorp)
Add native method calls to AndroidGamepadManager to replace the gamepad
events in GeckoEvent. Implement those calls in AndroidGamepad.cpp. The
jni/Refs.h change is necessary to fix a compile error when using
jni::BooleanArray.
Attachment #8775196 - Flags: review?(snorp)
Remove the now-obsolete gamepad events from GeckoEvent, along with a few
other used fields in GeckoEvent.
Attachment #8775198 - Flags: review?(snorp)
Attachment #8775195 - Flags: review?(snorp) → review+
Attachment #8775196 - Flags: review?(snorp) → review+
Attachment #8775198 - Flags: review?(snorp) → review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/10231cdd4c76
Move gamepad methods out of GeckoAppShell; r=snorp
https://hg.mozilla.org/integration/fx-team/rev/c016f9d74449
Add native methods to AndroidGamepadManager; r=snorp
https://hg.mozilla.org/integration/fx-team/rev/86b4155ce94b
Updated auto-generated bindings; r=me
https://hg.mozilla.org/integration/fx-team/rev/40578d56c4ff
Remove gamepad events from GeckoEvent; r=snorp
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: