Closed
Bug 1289208
Opened 8 years ago
Closed 8 years ago
Convert gamepad events to native methods
Categories
(Core Graveyard :: Widget: Android, defect, P3)
Tracking
(firefox51 fixed)
RESOLVED
FIXED
mozilla51
Tracking | Status | |
---|---|---|
firefox51 | --- | fixed |
People
(Reporter: jchen, Assigned: jchen)
References
Details
Attachments
(4 files)
5.90 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
10.84 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
14.02 KB,
patch
|
jchen
:
review+
|
Details | Diff | Splinter Review |
21.77 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
Convert the gamepad events in GeckoEvent to native method calls in AndroidGamepadManager, and also move gamepad-related methods in GeckoAppShell to AndroidGamepadManager.
Assignee | ||
Comment 1•8 years ago
|
||
Move gamepad methods called by native code out of GeckoAppShell and into AndroidGamepadManager.
Attachment #8775195 -
Flags: review?(snorp)
Assignee | ||
Comment 2•8 years ago
|
||
Add native method calls to AndroidGamepadManager to replace the gamepad events in GeckoEvent. Implement those calls in AndroidGamepad.cpp. The jni/Refs.h change is necessary to fix a compile error when using jni::BooleanArray.
Attachment #8775196 -
Flags: review?(snorp)
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8775197 -
Flags: review+
Assignee | ||
Comment 4•8 years ago
|
||
Remove the now-obsolete gamepad events from GeckoEvent, along with a few other used fields in GeckoEvent.
Attachment #8775198 -
Flags: review?(snorp)
Attachment #8775195 -
Flags: review?(snorp) → review+
Attachment #8775196 -
Flags: review?(snorp) → review+
Attachment #8775198 -
Flags: review?(snorp) → review+
Updated•8 years ago
|
Priority: -- → P3
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/10231cdd4c76 Move gamepad methods out of GeckoAppShell; r=snorp https://hg.mozilla.org/integration/fx-team/rev/c016f9d74449 Add native methods to AndroidGamepadManager; r=snorp https://hg.mozilla.org/integration/fx-team/rev/86b4155ce94b Updated auto-generated bindings; r=me https://hg.mozilla.org/integration/fx-team/rev/40578d56c4ff Remove gamepad events from GeckoEvent; r=snorp
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/10231cdd4c76 https://hg.mozilla.org/mozilla-central/rev/c016f9d74449 https://hg.mozilla.org/mozilla-central/rev/86b4155ce94b https://hg.mozilla.org/mozilla-central/rev/40578d56c4ff
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•