1289225 - Create tasks with parallelism of 50

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

The decision task creates a *lot* of tasks.  Within the queue service, each createTask is slow because the Azure table storage it uses as a backend is slow.  But concurrency should help!

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1289225: increase createTask concurrency;

Review commit: https://reviewboard.mozilla.org/r/66912/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/66912/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8774488 [details]
Bug 1289225: increase createTask concurrency;

https://reviewboard.mozilla.org/r/66912/#review63744

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

[34m 0:17.71(B[m Starting new HTTP connection (46): taskcluster
[34m 0:17.72(B[m Starting new HTTP connection (50): taskcluster
[34m 0:17.71(B[m Starting new HTTP connection (48): taskcluster
[34m 0:17.71(B[m Starting new HTTP connection (49): taskcluster
[34m 0:17.71(B[m Starting new HTTP connection (47): taskcluster

looks promising.. and only 8 seconds to create all of the tasks.

Comment 4

[Gregory Szorc [:gps]]

Nice. When I initially implemented the thread pool for concurrent upload, I thought the concurrency would be limited by availability of the task in the graph (we can only upload a task once its dependencies are uploaded). I guess we don't have enough long chains in the graph for this to be an issue.

Quick thing to verify: we don't actually establish a TCP connection unless it is needed, right? I'd hate to spawn 50 TCP connections and only use 5. (I /think/ I verified this before. But we may want to check again to be sure because 50 is a lot of connections!)

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8774488 [details]
Bug 1289225: increase createTask concurrency;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/66912/diff/1-2/

Comment 6

[Jonas Finnemann Jensen (:jonasfj)]

Comment on attachment 8774488 [details]
Bug 1289225: increase createTask concurrency;

https://reviewboard.mozilla.org/r/66912/#review63844

Yay...

Comment 7

[Jonas Finnemann Jensen (:jonasfj)]

> we don't actually establish a TCP connection unless it is needed, right?
50 is the number of threads. TCP connection establishment and keep-alive is probably abstracted
far away inside the requests library :)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9baa784f40f4
increase createTask concurrency; r=gps,jonasfj

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9baa784f40f4