Closed Bug 1289252 Opened 5 years ago Closed 5 years ago

gDEBUG_LiveProtoCount does not need to be modified atomically

Categories

(Core :: XPConnect, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

Details

Attachments

(1 file)

gDEBUG_LiveProtoCount is a debug-only counter of the number of live XPCWrappedNativeProtos. Currently, it is updated with PR_ATOMIC_INCREMENT/DECREMENT, presumably because XPConnect used to be multithreaded, but this is now unnecessary. This code looks essentially unchanged since the initial XPCDOM landing.
Attachment #8775205 - Flags: review?(mrbkap) → review+
Keywords: checkin-needed
Thanks for all of the various reviews.
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/de70d037b6b9
gDEBUG_LiveProtoCount does not need to be modified atomically. r=mrbkap
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/de70d037b6b9
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.