gDEBUG_LiveProtoCount does not need to be modified atomically

RESOLVED FIXED in Firefox 50

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

Trunk
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
gDEBUG_LiveProtoCount is a debug-only counter of the number of live XPCWrappedNativeProtos. Currently, it is updated with PR_ATOMIC_INCREMENT/DECREMENT, presumably because XPConnect used to be multithreaded, but this is now unnecessary. This code looks essentially unchanged since the initial XPCDOM landing.
(Assignee)

Comment 1

2 years ago
Created attachment 8775205 [details] [diff] [review]
gDEBUG_LiveProtoCount does not need to be modified atomically.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=de6442645240
Attachment #8775205 - Flags: review?(mrbkap)
Attachment #8775205 - Flags: review?(mrbkap) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
(Assignee)

Comment 2

2 years ago
Thanks for all of the various reviews.

Comment 3

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/de70d037b6b9
gDEBUG_LiveProtoCount does not need to be modified atomically. r=mrbkap
Keywords: checkin-needed

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/de70d037b6b9
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.