All users were logged out of Bugzilla on October 13th, 2018

Ensure printing works for PowerPlant embedding clients

RESOLVED FIXED in mozilla1.0

Status

--
critical
RESOLVED FIXED
17 years ago
2 years ago

People

(Reporter: mikepinkerton, Assigned: ccarlen)

Tracking

({topembed+})

Trunk
mozilla1.0
PowerPC
Mac OS X
topembed+

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
We need to make sure that our print architecture fits with powerplant's for CFM
embedding.

ccarlen said he would look into this.
(Reporter)

Updated

17 years ago
Blocks: 127253
Keywords: topembed
(Assignee)

Comment 1

17 years ago
I got this initially working. The calls to the printing APIs are encapsulated in
an LAttachment derived class. It allows you to attach printing functionality to
some CBrowserShells and not to others. Patch coming soon.
Status: NEW → ASSIGNED

Updated

17 years ago
Keywords: topembed → topembed+
(Assignee)

Comment 2

17 years ago
Now I just have to make sure it's working on Classic and whether the native
print progress impl is needed there - it's not on OS X.
Target Milestone: --- → mozilla1.0
(Assignee)

Comment 3

17 years ago
Created attachment 75000 [details] [diff] [review]
patch

Rod, Pink - Can you review?
(Reporter)

Updated

17 years ago
Attachment #75000 - Flags: review+
(Reporter)

Comment 4

17 years ago
Comment on attachment 75000 [details] [diff] [review]
patch

+    // In any case, we don't want Gecko to display its XUL progress dialog.
+    // Unfortunately, there is nothing in the printing API to control this -
+    // it's done through a pref :-( If you are distributing your own default
+    // prefs, this could be done there instead of programatically.

ugh, that's terrible. a bug should be filed and fixed before anything gets
frozen. 

r=pink
(Assignee)

Comment 5

17 years ago
Patrick - can you sr= this. BTW, from comment #4, I talked to Rod and the
ability to control what UI is shown for print progress will be added to printing
APIs.

Comment 6

17 years ago
Comment on attachment 75000 [details] [diff] [review]
patch

Nit, 

+    *aSettings = mPrintSettings;
+    NS_IF_ADDREF(*aSettings);
+    return *aSettings ? NS_OK : NS_ERROR_FAILURE;

could be written more concisely, fewer tests, etc. as:

if ( mPrintSettings) {
  *aSettings = mPrintSettings;
  NS_ADDREF(mPrintSettings);
  return NS_OK;
}
return NS_ERROR_FAILURE;

sr=beard
Attachment #75000 - Flags: superreview+
(Assignee)

Comment 7

17 years ago
> could be written more concisely, fewer tests, etc. as:
True - I'll make the change.
Component: Embedding: Docshell → Embedding: Mac

Comment 8

17 years ago
Comment on attachment 75000 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #75000 - Flags: approval+
(Assignee)

Comment 9

17 years ago
Checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.