1289271 - |make check| busted due to using the wrong objdir path

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Edmund Wong (:ewong)]

we're getting this orange bustage in our builds:

TEST-PASS | /builds/slave/c-cen-t-lnx/build/mozilla/python/mozbuild/mozbuild/test/action/test_generate_browsersearch.py | TestGenerateBrowserSearch.test_valid_unicode
Traceback (most recent call last):
  File "/builds/slave/c-cen-t-lnx/build/mozilla/python/mozbuild/mozbuild/test/action/test_package_fennec_apk.py", line 13, in <module>
    from mozbuild.action.package_fennec_apk import (
  File "/builds/slave/c-cen-t-lnx/build/mozilla/build/mach_bootstrap.py", line 369, in __call__
    module = self._original_import(name, globals, locals, fromlist, level)
  File "/builds/slave/c-cen-t-lnx/build/mozilla/python/mozbuild/mozbuild/action/package_fennec_apk.py", line 12, in <module>
    import buildconfig
  File "/builds/slave/c-cen-t-lnx/build/mozilla/build/mach_bootstrap.py", line 369, in __call__
    module = self._original_import(name, globals, locals, fromlist, level)
  File "/builds/slave/c-cen-t-lnx/build/mozilla/build/buildconfig.py", line 9, in <module>
    config = MozbuildObject.from_environment()
  File "/builds/slave/c-cen-t-lnx/build/mozilla/python/mozbuild/mozbuild/base.py", line 183, in from_environment
    if not samepath(topobjdir, _config_topobjdir):
  File "/builds/slave/c-cen-t-lnx/build/mozilla/python/mozbuild/mozbuild/base.py", line 46, in samepath
    return os.path.samefile(path1, path2)
  File "/builds/slave/c-cen-t-lnx/build/objdir/_virtualenv/lib/python2.7/posixpath.py", line 163, in samefile
    s2 = os.stat(f2)
OSError: [Errno 2] No such file or directory: '/builds/slave/c-cen-t-lnx/build/mozilla/objdir'


And with bug 1208852, bug 1281086 and bug 1281676, I'm wondering if we
should just put the TOOLTOOL_DIR env in one of those basic steps?

Comment 1

[Edmund Wong (:ewong)]

TOOLTOOL_DIR env my foot... need to set the full path of the
OBJDIR..

Comment 2

[Edmund Wong (:ewong)]

Attachment: [buildbotcustom] proposed patch (v1)

Comment 3

[Edmund Wong (:ewong)]

Attachment: [buildbotcustom] proposed patch (v2)

Comment 4

[Edmund Wong (:ewong)]

Attachment: [buildbotcustom] proposed patch (v3)

Comment 5

[Justin Wood (:Callek)]

Comment on attachment 8776455 [details] [diff] [review]
[buildbotcustom] proposed patch (v3)

Review of attachment 8776455 [details] [diff] [review]:
-----------------------------------------------------------------

I feel like this is a hack, but most of buildbot is at this point. r+

Comment 6

[Edmund Wong (:ewong)]

https://hg.mozilla.org/build/buildbotcustom/rev/e14ae68acba285de0c97fab3cfebc8defcc836ef
Bug 1289271 - Add MOZ_OBJDIR to the |make check| step. r=Callek