Move MT detection to python configure

RESOLVED FIXED in Firefox 50

Status

()

Core
Build Config
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

(Blocks: 1 bug)

unspecified
mozilla50
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

a year ago
Created attachment 8774639 [details]
Bug 1289294 - Move MT detection to python configure.

Review commit: https://reviewboard.mozilla.org/r/67100/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67100/
Attachment #8774639 - Flags: review?(cmanchester)
Attachment #8774639 - Flags: review?(cmanchester) → review+
Comment on attachment 8774639 [details]
Bug 1289294 - Move MT detection to python configure.

https://reviewboard.mozilla.org/r/67100/#review64326
(Assignee)

Comment 3

a year ago
Comment on attachment 8774639 [details]
Bug 1289294 - Move MT detection to python configure.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/67100/diff/1-2/

Comment 4

a year ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/a9896c4309bb
Move MT detection to python configure. r=chmanchester

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a9896c4309bb
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
This seems to have broken my build on Windows 10 (Insider build), where the mt.exe I have does not report any version number. Previously, it looks like failure to read the MT version would issue a warning, but continue; now, it's a fatal configure-time error. :(
(Assignee)

Comment 7

a year ago
Where is your MT, and what does running it without arguments print out?
$ which mt
/c/Program Files (x86)/Windows Kits/10/bin/x64/mt.exe

$ mt
Microsoft (R) Manifest Tool
Copyright (c) Microsoft Corporation.
All rights reserved.

Usage:
-----
mt.exe
    [ -manifest <manifest1 name> <manifest2 name> ... ]
    [ -identity:<identity string> ]
    [ < <[-rgs:<.rgs filename>] [-tlb:<.tlb filename>]> -dll:<filename> > [ -replacements:<XML filename> ] ]
    [ -managedassemblyname:<managed assembly> [ -nodependency ] ]
    [ -out:<output manifest name> ]
    [ -inputresource:<file>[;[#]<resource_id>] ]
    [ -outputresource:<file>[;[#]<resource_id>] ]
    [ -updateresource:<file>[;[#]<resource_id>] ]
    [ -hashupdate[:<path to the files>] ]
    [ -makecdfs ]
    [ -validate_manifest ]
    [ -validate_file_hashes:<path to the files> ]
    [ -canonicalize ]
    [ -check_for_duplicates ]
    [ -nologo ]

...followed by extensive help about the options.
(Assignee)

Comment 9

a year ago
O_o this doesn't match what mt's output looks like on my sdk 10... wtf? Please file a followup bug, with, additionally, the list of directories under /c/Program Files (x86)/Windows Kits/10/Include.
I hit same issue.  I use insider version of Windows SDK 10 (10.0.14383.0) from https://developer.microsoft.com/en-us/windows/downloads/windows-10-developer-preview.
Depends on: 1290019
You need to log in before you can comment on or make changes to this bug.