Remove the call to Shutdown() from MediaDecoder::NetworkError()

RESOLVED FIXED in Firefox 50

Status

()

Core
Audio/Video: Playback
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Like bug 1289295, HTMLMediaElement::NetworkError() already calls MediaDecoder::Shutdown().
(Assignee)

Updated

a year ago
Assignee: nobody → jwwang
Blocks: 1289288
Priority: -- → P3
(Assignee)

Comment 1

a year ago
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bbed41e95fea
(Assignee)

Comment 2

a year ago
Created attachment 8774668 [details]
Bug 1289301 - Remove the call to Shutdown() from MediaDecoder::NetworkError().

Review commit: https://reviewboard.mozilla.org/r/67118/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67118/
Attachment #8774668 - Flags: review?(cpearce)
Comment on attachment 8774668 [details]
Bug 1289301 - Remove the call to Shutdown() from MediaDecoder::NetworkError().

https://reviewboard.mozilla.org/r/67118/#review64596

::: dom/media/MediaDecoder.cpp
(Diff revision 1)
>  MediaDecoder::NetworkError()
>  {
>    MOZ_ASSERT(NS_IsMainThread());
>    MOZ_ASSERT(!IsShutdown());
>    mOwner->NetworkError();
> -  Shutdown();

You could assert here that Shutdown() has been called.
Attachment #8774668 - Flags: review?(cpearce) → review+
(Assignee)

Comment 4

a year ago
https://reviewboard.mozilla.org/r/67118/#review64596

> You could assert here that Shutdown() has been called.

Will do. Thanks for the review!
(Assignee)

Comment 5

a year ago
Comment on attachment 8774668 [details]
Bug 1289301 - Remove the call to Shutdown() from MediaDecoder::NetworkError().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/67118/diff/1-2/

Comment 6

a year ago
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/72f738a49d10
Remove the call to Shutdown() from MediaDecoder::NetworkError(). r=cpearce

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/72f738a49d10
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.