1289322 - Link clicking is detected in the wrong location

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Toolbar, defect, P2)

Description

[Gian-Carlo Pascutto [:gcp]]

Nexus 7 2013, Android 6.0.1, latest Nightly

1) visit https://reddit.com/r/nvidia
2) pan/zoom to "Related Subreddits"
3) attempt to click /r/hardware

actual result:

Tapping the link has no effect. If something does happen, an unrelated comment is usually opened, but not the /r/hardware link that was being tapped.

It looks as if the clicking is detected in the wrong location.

This is not a very recent regression, but this used to work.

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

bug 1274597?

Comment 2

[Gian-Carlo Pascutto [:gcp]]

I've seen the behavior described in bug 1274597 as well but I'm not 100% sure this is the same. This is quite reproducible for me.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

[Tracking Requested - why for this release]:

Comment 4

[Randall Barker [:rbarker]]

Attachment: 0001-Bug-1289322-Link-clicking-is-detected-in-the-wrong-location-r-kats-16072614-01385d6.patch

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Patch looks reasonable but I wouldn't want to uplift this because the codepath is brittle.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1ac662342a2
Link clicking is detected in the wrong location r=kats

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c1ac662342a2

Comment 8

[Teodora Vermesan (:TeoVermesan)]

Tapping the "/r/hardware" will open another link in the same tab, so:
Verified as fixed using:
Device: One A2001 (Android 5.1.1)
Build: Firefox for Android 50.0a1 (2016-07-28)

Tapping "I agree" from the cookie dialog sometimes does nothing, when the page is zoomed in. Please take a look at the following video: https://youtu.be/ej8Cs3qBxzI
This worked fine on the 27-07 build.

Comment 9

[James Willcox (:snorp) ([e-mail]) (he/him)]

Kats, would you consider uplifting this to 49 once the Beta cycle starts? That way we'll have plenty of time to see if it hoses anything. The bug itself is pretty bad, though I know we also have other causes for this.

Comment 10

[Kartikaya Gupta (email:[e-mail])]

I'd like to wait at least a week or two after the merge before considering uplift. There is a relatively high risk of regressions from this, and I want to give Aurora users some time to report issues they might run into.

Relatedly, can you respond to the needinfo on bug 1280666?

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Not sure we have enough aurora users to get proper testing. Anyway, tracking for 49. Liz will make the call.

Comment 12

[Liz Henry (:lizzard)]

If you want to try uplift, the next fennec build will be for beta 4 next Monday morning. I'm open to trying it for beta 4.

Comment 13

[Gerry Chang [:gchang]]

Hi Randall,
Since this patch also affects 49, are you also considering to uplift this patch to 49?

Comment 14

[Randall Barker [:rbarker]]

Comment on attachment 8774898 [details] [diff] [review]
0001-Bug-1289322-Link-clicking-is-detected-in-the-wrong-location-r-kats-16072614-01385d6.patch

Approval Request Comment
[Feature/regressing bug #]:APZ and Gecko get out of sync and touch points get incorrectly translated for gecko causing tapping on links to fail.
[User impact if declined]: touches will appear to be in the incorrect location on a page.
[Describe test coverage new/current, TreeHerder]: manual
[Risks and why]: Might cause other side effects related to touch events. The code is very fragile.
[String/UUID change made/needed]: none.

Comment 15

[Kevin Brosnan [Ex-Mozilla]]

This is already in Aurora 50.0a2. 49 would be beta. Randall are you comfortable with uplifting this to beta? It will have about 4 weeks until 49.0 goes to release.

Comment 16

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8774898 [details] [diff] [review]
0001-Bug-1289322-Link-clicking-is-detected-in-the-wrong-location-r-kats-16072614-01385d6.patch

Like Kevin said this is already on 50 (Aurora). Flipping the uplift flag to Beta (49), please feel free to un-nominate if this is deemed risky for 49.

Comment 17

[Randall Barker [:rbarker]]

(In reply to Kevin Brosnan [:kbrosnan] from comment #15)
> This is already in Aurora 50.0a2. 49 would be beta. Randall are you
> comfortable with uplifting this to beta? It will have about 4 weeks until
> 49.0 goes to release.

Sorry, got confused. I think it should be uplifted since nothing seems to have blow up (yet).

Comment 18

[Kartikaya Gupta (email:[e-mail])]

Given the bake time and lack of regressions so far I'm also ok with uplifting this to beta now.

Comment 19

[Liz Henry (:lizzard)]

Comment on attachment 8774898 [details] [diff] [review]
0001-Bug-1289322-Link-clicking-is-detected-in-the-wrong-location-r-kats-16072614-01385d6.patch

Thanks everyone. This should make it into the beta 5 build (so, the beta 6 fennec release next Tuesday).

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/00cc1779c7d7

Comment 21

[Teodora Vermesan (:TeoVermesan)]

Tapping the "/r/hardware" will open the link in the same tab, so:
Verified as fixed using:
Device: Nexus 6 (Android 6.0)
Build: Firefox for Android 49 Beta 6