SSL_DHEGroupPrefSet: restore the ability to control the default group

RESOLVED FIXED in 3.26

Status

NSS
Libraries
--
blocker
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: kaie, Assigned: mt)

Tracking

({regression})

3.26
3.26
regression

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
As mentioned by Martin in bug 1286141 comment 1, there's a regression, the code no longer treats the first parameter as the default group.

Could you please restore the documented behavior? Thanks in advance.

IMHO this should be considered a blocker for the 3.26 release.
(Assignee)

Comment 1

2 years ago
Created attachment 8774670 [details] [diff] [review]
bug1289328-1.patch

This should work.  I've taken the tests from bug 1286141.  I will check that this backports cleanly, but I think that it shouldn't hurt too much.
Attachment #8774670 - Flags: review?(kaie)
(Reporter)

Comment 3

2 years ago
Comment on attachment 8774670 [details] [diff] [review]
bug1289328-1.patch

r=kaie, thank you Martin!
Attachment #8774670 - Flags: review?(kaie) → review+
(Assignee)

Comment 4

2 years ago
https://hg.mozilla.org/projects/nss/rev/f92631b5152c - trunk
https://hg.mozilla.org/projects/nss/rev/34facc84fb44 - 3_26
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.