HTMLMediaElement::ResetConnectionState() should shut down the decoder

RESOLVED FIXED in Firefox 50

Status

()

Core
Audio/Video: Playback
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
MediaDecoder::ResetConnectionState() calls Shutdown(). It is suspicious for HTMLMediaElement to hold a decoder that is shut down which it can't do anything useful with.

HTMLMediaElement::ResetConnectionState() should drop the reference and shut down the decoder as HTMLMediaElement::NetworkError() does.
(Assignee)

Updated

a year ago
Assignee: nobody → jwwang
Blocks: 1289288
Priority: -- → P3
(Assignee)

Comment 1

a year ago
Created attachment 8774669 [details]
Bug 1289334 - HTMLMediaElement::ResetConnectionState() should shut down the decoder.

Review commit: https://reviewboard.mozilla.org/r/67122/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67122/
Attachment #8774669 - Flags: review?(cpearce)
Comment on attachment 8774669 [details]
Bug 1289334 - HTMLMediaElement::ResetConnectionState() should shut down the decoder.

https://reviewboard.mozilla.org/r/67122/#review64598
Attachment #8774669 - Flags: review?(cpearce) → review+
(Assignee)

Comment 3

a year ago
Thanks!
(Assignee)

Comment 4

a year ago
Comment on attachment 8774669 [details]
Bug 1289334 - HTMLMediaElement::ResetConnectionState() should shut down the decoder.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/67122/diff/1-2/

Comment 5

a year ago
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b582a8dc13c3
HTMLMediaElement::ResetConnectionState() should shut down the decoder. r=cpearce

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b582a8dc13c3
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.