Remove typeof win.foo == "function" checks in CustomizableWidgets.jsm

RESOLVED FIXED in Firefox 50

Status

()

Firefox
Toolbars and Customization
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: dao, Unassigned, Mentored)

Tracking

Trunk
Firefox 50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

(Whiteboard: [good first bug][lang=js])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
These functions should be guaranteed to exist, so the checks are pointless:

https://dxr.mozilla.org/mozilla-central/search?q=file%3ACustomizableWidgets.jsm+%27%3D%3D+%22function%22%27&redirect=false
Created attachment 8775745 [details] [diff] [review]
Bug 1289358 : Remove typeof win.foo == "function" checks

Remove checks as the functions are guaranteed to exist.
Attachment #8775745 - Flags: review?(dao+bmo)
(Reporter)

Comment 2

2 years ago
Comment on attachment 8775745 [details] [diff] [review]
Bug 1289358 : Remove typeof win.foo == "function" checks

Looks good. Thanks!
Attachment #8775745 - Flags: review?(dao+bmo) → review+

Comment 3

2 years ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/7fdbf2f6db18
Remove typeof win.foo == "function" checks. r=dao

Comment 4

2 years ago
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/fx-team/rev/06e51ce8f72f
Remove typeof win.foo == "function" checks: Remove trailing whitespaces. r=eslint-fix

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7fdbf2f6db18
https://hg.mozilla.org/mozilla-central/rev/06e51ce8f72f
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
You need to log in before you can comment on or make changes to this bug.