Closed Bug 1289358 Opened 3 years ago Closed 3 years ago
Remove typeof win
.foo == "function" checks in Customizable Widgets .jsm
These functions should be guaranteed to exist, so the checks are pointless: https://dxr.mozilla.org/mozilla-central/search?q=file%3ACustomizableWidgets.jsm+%27%3D%3D+%22function%22%27&redirect=false
Remove checks as the functions are guaranteed to exist.
Attachment #8775745 - Flags: review?(dao+bmo)
Comment on attachment 8775745 [details] [diff] [review] Bug 1289358 : Remove typeof win.foo == "function" checks Looks good. Thanks!
Attachment #8775745 - Flags: review?(dao+bmo) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/fx-team/rev/7fdbf2f6db18 Remove typeof win.foo == "function" checks. r=dao
Pushed by email@example.com: https://hg.mozilla.org/integration/fx-team/rev/06e51ce8f72f Remove typeof win.foo == "function" checks: Remove trailing whitespaces. r=eslint-fix
You need to log in before you can comment on or make changes to this bug.