Closed Bug 1289358 Opened 3 years ago Closed 3 years ago

Remove typeof win.foo == "function" checks in CustomizableWidgets.jsm

Categories

(Firefox :: Toolbars and Customization, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 50
Tracking Status
firefox50 --- fixed

People

(Reporter: dao, Unassigned, Mentored)

Details

(Whiteboard: [good first bug][lang=js])

Attachments

(1 file)

Remove checks as the functions are guaranteed to exist.
Attachment #8775745 - Flags: review?(dao+bmo)
Comment on attachment 8775745 [details] [diff] [review]
Bug 1289358 : Remove typeof win.foo == "function" checks

Looks good. Thanks!
Attachment #8775745 - Flags: review?(dao+bmo) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/7fdbf2f6db18
Remove typeof win.foo == "function" checks. r=dao
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/fx-team/rev/06e51ce8f72f
Remove typeof win.foo == "function" checks: Remove trailing whitespaces. r=eslint-fix
https://hg.mozilla.org/mozilla-central/rev/7fdbf2f6db18
https://hg.mozilla.org/mozilla-central/rev/06e51ce8f72f
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
You need to log in before you can comment on or make changes to this bug.