Closed Bug 1289380 Opened 3 years ago Closed 3 years ago

Simplify PersistentBufferProviderShared

Categories

(Core :: Graphics: Layers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: nical, Assigned: nical)

References

(Blocks 1 open bug)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

I shuffled things around a bit while investigating various copy-on-write canvas issues. I find the resulting code easier to understand, and it provides more control over when to remove the textures to avoid racing with layer transactions.
Whiteboard: [gfx-noted]
This makes PersistentBufferProviderShared store a vector of textures and use indices to tell which is the front and back buffers. It makes debugging easier by making the number of textures allocated explicit and makes sure we don't clear used textures from outside of a transaction.
Some other small fixes got folded in by accident, they are probably not worth filing bugs for:
 * make sure we don't use PersistentBufferProviderShared with skiagl
 * make sure we don't accidentally pass the global error target to the buffer provider.
Attachment #8774699 - Flags: review?(edwin)
Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc5b4f286716
Simplify PersistentBufferProviderShared. r=edwin
Blocks: 1290072
https://hg.mozilla.org/mozilla-central/rev/fc5b4f286716
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Depends on: 1361574
You need to log in before you can comment on or make changes to this bug.