1289407 - [Static Analysis][Uninitialized scalar field] In constructor nsDisplayItem(nsIFrame* aFrame)

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity detected that |mForceNotVisible| is not initialised in the following context:

>>  explicit nsDisplayItem(nsIFrame* aFrame)
>>    : mFrame(aFrame)
>>    , mClip(nullptr)
>>    , mScrollClip(nullptr)
>>    , mReferenceFrame(nullptr)
>>    , mAnimatedGeometryRoot(nullptr)
>>#ifdef MOZ_DUMP_PAINTING
>>    , mPainted(false)
>>#endif
>>  {
>>  }

In order to integrate our static analysis tool that checks for uninitialised member variables we need this to be initialised for marked as skipped, like 1282408, but judging from the context i think we can initialise it with false.

Comment 1

[Andi [:andi]]

Attachment: Bug 1289407 - initialise |mForceNotVisible| in explicit ctor.

Review commit: https://reviewboard.mozilla.org/r/67162/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67162/

Comment 2

[Timothy Nikkel (:tnikkel)]

Comment on attachment 8774721 [details]
Bug 1289407 - initialise |mForceNotVisible| in explicit ctor.

https://reviewboard.mozilla.org/r/67162/#review64094

Thanks. We'll want to uplift to aurora and beta because the patch that caused this has been uplifted.

Comment 3

[Timothy Nikkel (:tnikkel)]

Comment on attachment 8774721 [details]
Bug 1289407 - initialise |mForceNotVisible| in explicit ctor.

Actually, probably too late for beta.

Approval Request Comment
[Feature/regressing bug #]: bug 1276467
[User impact if declined]: fix for bug 1276467 (which we uplifted) might not get applied in the right cases
[Describe test coverage new/current, TreeHerder]: nope
[Risks and why]: safe
[String/UUID change made/needed]: none

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d4ebd027c42
initialise |mForceNotVisible| in explicit ctor. r=tnikkel

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1d4ebd027c42

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8774721 [details]
Bug 1289407 - initialise |mForceNotVisible| in explicit ctor.

sure, let's take it

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/11204e05dff9