Closed
Bug 1289455
Opened 8 years ago
Closed 8 years ago
Obviate manual CERT_DestroyCertificate() calls in PSM
Categories
(Core :: Security: PSM, defect, P1)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: Cykesiopka, Assigned: Cykesiopka)
References
Details
(Whiteboard: [psm-assigned])
Attachments
(1 file)
Less manual memory management is good.
|
Assignee | |
Updated•8 years ago
|
Summary: Obviate CERT_DestroyCertificate() calls in PSM using UniqueCERTCertificate → Obviate manual CERT_DestroyCertificate() calls in PSM
|
|
Assignee | |
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/69690/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/69690/
Attachment #8778372 -
Flags: review?(dkeeler)
|
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8778372 [details] Bug 1289455 - Obviate manual CERT_DestroyCertificate() calls in PSM. https://reviewboard.mozilla.org/r/69690/#review67824 Great - r=me. Along these lines, I was thinking about making it so the array of nsMyTrustedEVInfo doesn't even need to keep a handle on each root certificate (comparing serial number, issuer, and sha-256 hash should be sufficient). This might save us a little bit of memory. Also, some of the code in ExtendedValidation.cpp could be improved, style-wise, but it really isn't urgent.
Attachment #8778372 -
Flags: review?(dkeeler) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8778372 [details] Bug 1289455 - Obviate manual CERT_DestroyCertificate() calls in PSM. https://reviewboard.mozilla.org/r/69690/#review67824 Thanks! I played around with getting rid of the cert handle, but a naive removal didn't pass tests. I'll poke around more and file a bug I guess.
|
|
Assignee | |
Comment 4•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b3697d4bcd39 (The oranges look like intermittents or failures from the base revision.)
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7afd32fc3da6 Obviate manual CERT_DestroyCertificate() calls in PSM. r=dkeeler
Keywords: checkin-needed
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7afd32fc3da6
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•