Improve example codegen for maplike/setlike/iterable declarations

RESOLVED FIXED in Firefox 50

Status

()

Core
DOM
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: bz, Assigned: bz)

Tracking

(Blocks: 1 bug)

Trunk
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(4 attachments, 2 obsolete attachments)

1.36 KB, patch
qdot
: review+
Details | Diff | Splinter Review
3.72 KB, patch
qdot
: review+
Details | Diff | Splinter Review
1.95 KB, patch
qdot
: review+
Details | Diff | Splinter Review
2.81 KB, patch
qdot
: review+
Details | Diff | Splinter Review
Right now we do some odd things in there.
Created attachment 8774764 [details] [diff] [review]
part 1.  Example codegen generation should print out which files it generated, so it's easy to examine them
Attachment #8774764 - Flags: review?(kyle)
Created attachment 8774765 [details] [diff] [review]
part 2.  Skip example codegen for methods/attributes on maplikes/setlikes/iterables that we auto-generate an implementation for
Attachment #8774765 - Flags: review?(kyle)
Created attachment 8774766 [details] [diff] [review]
part 3.  Skip forward-declaring types used by methods/attributes on maplikes/setlikes/iterables taht we auto-generate an implementation for
Attachment #8774766 - Flags: review?(kyle)
Created attachment 8774767 [details] [diff] [review]
part 4.  Make ForwardDeclarationBuilder to error out if asked to forward-declare a templated type instead of spitting out nonsense that doesn't compile
Attachment #8774767 - Flags: review?(kyle)
Created attachment 8774768 [details] [diff] [review]
part 3.  Skip forward-declaring types used by methods/attributes on maplikes/setlikes/iterables that we auto-generate an implementation for
Attachment #8774768 - Flags: review?(kyle)
Attachment #8774766 - Attachment is obsolete: true
Attachment #8774766 - Flags: review?(kyle)
Created attachment 8774769 [details] [diff] [review]
part 4.  Make ForwardDeclarationBuilder error out if asked to forward-declare a templated type instead of spitting out nonsense that doesn't compile
Attachment #8774769 - Flags: review?(kyle)
Attachment #8774767 - Attachment is obsolete: true
Attachment #8774767 - Flags: review?(kyle)
Comment on attachment 8774764 [details] [diff] [review]
part 1.  Example codegen generation should print out which files it generated, so it's easy to examine them

Review of attachment 8774764 [details] [diff] [review]:
-----------------------------------------------------------------

I am for this.
Attachment #8774764 - Flags: review?(kyle) → review+
Attachment #8774765 - Flags: review?(kyle) → review+
Attachment #8774768 - Flags: review?(kyle) → review+
Attachment #8774769 - Flags: review?(kyle) → review+

Comment 8

a year ago
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f20718aff215
part 1.  Example codegen generation should print out which files it generated, so it's easy to examine them.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/22f5e81b7587
part 2.  Skip example codegen for methods/attributes on maplikes/setlikes/iterables that we auto-generate an implementation for.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1031a67635a
part 3.  Skip forward-declaring types used by methods/attributes on maplikes/setlikes/iterables that we auto-generate an implementation for.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/2bf4894c52c9
part 4.  Make ForwardDeclarationBuilder error out if asked to forward-declare a templated type instead of spitting out nonsense that doesn't compile.  r=qdot

Comment 9

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f20718aff215
https://hg.mozilla.org/mozilla-central/rev/22f5e81b7587
https://hg.mozilla.org/mozilla-central/rev/d1031a67635a
https://hg.mozilla.org/mozilla-central/rev/2bf4894c52c9
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.