Closed Bug 1289467 Opened 4 years ago Closed 4 years ago

Improve example codegen for maplike/setlike/iterable declarations

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(4 files, 2 obsolete files)

Right now we do some odd things in there.
Attachment #8774766 - Attachment is obsolete: true
Attachment #8774766 - Flags: review?(kyle)
Attachment #8774767 - Attachment is obsolete: true
Attachment #8774767 - Flags: review?(kyle)
Comment on attachment 8774764 [details] [diff] [review]
part 1.  Example codegen generation should print out which files it generated, so it's easy to examine them

Review of attachment 8774764 [details] [diff] [review]:
-----------------------------------------------------------------

I am for this.
Attachment #8774764 - Flags: review?(kyle) → review+
Attachment #8774765 - Flags: review?(kyle) → review+
Attachment #8774768 - Flags: review?(kyle) → review+
Attachment #8774769 - Flags: review?(kyle) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f20718aff215
part 1.  Example codegen generation should print out which files it generated, so it's easy to examine them.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/22f5e81b7587
part 2.  Skip example codegen for methods/attributes on maplikes/setlikes/iterables that we auto-generate an implementation for.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1031a67635a
part 3.  Skip forward-declaring types used by methods/attributes on maplikes/setlikes/iterables that we auto-generate an implementation for.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/2bf4894c52c9
part 4.  Make ForwardDeclarationBuilder error out if asked to forward-declare a templated type instead of spitting out nonsense that doesn't compile.  r=qdot
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.