1289467 - Improve example codegen for maplike/setlike/iterable declarations

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Right now we do some odd things in there.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Example codegen generation should print out which files it generated, so it's easy to examine them

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Skip example codegen for methods/attributes on maplikes/setlikes/iterables that we auto-generate an implementation for

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Skip forward-declaring types used by methods/attributes on maplikes/setlikes/iterables taht we auto-generate an implementation for

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 4. Make ForwardDeclarationBuilder to error out if asked to forward-declare a templated type instead of spitting out nonsense that doesn't compile

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Skip forward-declaring types used by methods/attributes on maplikes/setlikes/iterables that we auto-generate an implementation for

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: part 4. Make ForwardDeclarationBuilder error out if asked to forward-declare a templated type instead of spitting out nonsense that doesn't compile

Comment 7

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8774764 [details] [diff] [review]
part 1.  Example codegen generation should print out which files it generated, so it's easy to examine them

Review of attachment 8774764 [details] [diff] [review]:
-----------------------------------------------------------------

I am for this.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f20718aff215
part 1.  Example codegen generation should print out which files it generated, so it's easy to examine them.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/22f5e81b7587
part 2.  Skip example codegen for methods/attributes on maplikes/setlikes/iterables that we auto-generate an implementation for.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1031a67635a
part 3.  Skip forward-declaring types used by methods/attributes on maplikes/setlikes/iterables that we auto-generate an implementation for.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/2bf4894c52c9
part 4.  Make ForwardDeclarationBuilder error out if asked to forward-declare a templated type instead of spitting out nonsense that doesn't compile.  r=qdot

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f20718aff215
https://hg.mozilla.org/mozilla-central/rev/22f5e81b7587
https://hg.mozilla.org/mozilla-central/rev/d1031a67635a
https://hg.mozilla.org/mozilla-central/rev/2bf4894c52c9