Closed
Bug 1289468
Opened 8 years ago
Closed 8 years ago
[Static Analysis][Uninitialized scalar field] In constructor ChromeTooltipListener(nsWebBrowser* aInBrowser, nsIWebBrowserChrome* aInChrome)
Categories
(Firefox :: Untriaged, defect)
Firefox
Untriaged
Tracking
()
RESOLVED
FIXED
Firefox 50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: paul.bignier, Assigned: paul.bignier)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: [CID 749953])
Attachments
(1 file)
|
1.30 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0 Build ID: 20160608174051 Steps to reproduce: 'mMouseScreenX' & 'mMouseScreenY' are used in MouseMove() & sTooltipCallback(). They are initialized in MouseMove() but not in sTooltipCallback(). 'mMouseClientX' & 'mMouseClientY' are already ctor-initialized, so 'mMouseScreenX' & 'mMouseScreenY' simply follow their lead.
|
Assignee | |
Updated•8 years ago
|
Attachment #8774756 -
Flags: review?(bpostelnicu)
|
||
Comment 1•8 years ago
|
||
Comment on attachment 8774756 [details] [diff] [review] 0001-Static-Analysis-Uninitialized-scalar-field-In-constr.patch LGTM, but i'm not a reviewer so passing it Dave/
Attachment #8774756 -
Flags: review?(bpostelnicu) → review?(dcamp)
|
||
Updated•8 years ago
|
Attachment #8774756 -
Flags: review?(dcamp) → review?(mconley)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8774756 [details] [diff] [review] 0001-Static-Analysis-Uninitialized-scalar-field-In-constr.patch Review of attachment 8774756 [details] [diff] [review]: ----------------------------------------------------------------- Looks good - thanks!
Attachment #8774756 -
Flags: review?(mconley) → review+
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed,
coverity
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/96de0b18cace [Static Analysis][Uninitialized scalar field] In constructor ChromeTooltipListener(nsWebBrowser* aInBrowser, nsIWebBrowserChrome* aInChrome). r=mconley
Keywords: checkin-needed
|
||
Updated•8 years ago
|
Assignee: nobody → paul.bignier
|
|
||
Updated•8 years ago
|
Blocks: coverity-analysis
Whiteboard: [CID 749953]
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/96de0b18cace
Status: UNCONFIRMED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
You need to log in
before you can comment on or make changes to this bug.
Description
•