1289505 - ../../../../dist/include/nsStringAPI.h:1019: error: undefined reference to 'NS_CStringContainerInit'

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[:gerard-majax]

https://treeherder.mozilla.org/#/jobs?repo=pine&revision=2225f87f111d53651fb860cd3f783b8b64c3ed3e&filter-tier=1&filter-tier=2&filter-tier=3&selectedJob=47037

Comment 1

[:gerard-majax]

Likely because of bug 1274540

Comment 2

[Haik Aftandilian [:haik]]

This looks like a dupe of bug 1289381. Could you confirm?

Comment 3

[:gerard-majax]

It is not exactly the same issue. Builds are currently with --enable-crashreporter.

Comment 4

[:gerard-majax]

../../../../dist/include/nsStringAPI.h:1019: error: undefined reference to 'NS_CStringContainerInit'
../../../../../../../../../gecko-cinnabar/security/sandbox/linux/common/SandboxInfo.cpp:290: error: undefined reference to 'nsACString::AppendInt(int, int)'
../../../../dist/include/nsStringAPI.h:1081: error: undefined reference to 'NS_CStringContainerInit2'
../../../../../../../../../gecko-cinnabar/security/sandbox/linux/common/SandboxInfo.cpp:293: error: undefined reference to 'CrashReporter::AnnotateCrashReport(nsACString const&, nsACString const&)'
../../../../dist/include/nsStringAPI.h:1042: error: undefined reference to 'NS_CStringContainerFinish'
../../../../dist/include/nsStringAPI.h:1042: error: undefined reference to 'NS_CStringContainerFinish'

Comment 5

[:gerard-majax]

Attachment: Gonk-misc PR

Comment 6

[:gerard-majax]

https://github.com/mozilla-b2g/gonk-misc/commit/99003a6e7ecee880330a3fb8b5e49fefdb762374

Comment 7

[:gerard-majax]

Attachment: Bug 1289505 - Update gaia/gonk-misc repos

Review commit: https://reviewboard.mozilla.org/r/67238/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67238/

Comment 8

[:gerard-majax]

Comment on attachment 8774838 [details]
Bug 1289505 - Update gaia/gonk-misc repos

https://reviewboard.mozilla.org/r/67238/#review64152

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05963fe43d95
Update gaia/gonk-misc repos r=me

Comment 10

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

(In reply to Alexandre LISSY :gerard-majax from comment #4)
> ../../../../../../../../../gecko-cinnabar/security/sandbox/linux/common/
> SandboxInfo.cpp:290: error: undefined reference to
> 'nsACString::AppendInt(int, int)'
> ../../../../../../../../../gecko-cinnabar/security/sandbox/linux/common/
> SandboxInfo.cpp:293: error: undefined reference to
> 'CrashReporter::AnnotateCrashReport(nsACString const&, nsACString const&)'

Sorry; I should have caught this.  SandboxInfo is currently linked into libxul.so on desktop, so using libxul stuff directly happens to work, but it's in libmozsandbox.so on B2G (and might move back into libmozsandbox.so on desktop in the future).  This function really should live in libxul (see also security/sandbox/linux/glue); nothing that's simply reading the SandboxInfo flags actually needs to be a member of the SandboxInfo class.

And from a quick look at the code it looks like the SandboxInfo Telemetry integration should break the same way, but maybe I'm missing something?

In any case, if there's already an acceptable workaround for B2G then nothing in this comment necessarily needs to be acted on now, but someone (possibly me) is probably going to have to fix things at some point.

Comment 11

[:gerard-majax]

Well we disable crash reporter, it's easier for everyone.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/05963fe43d95