Closed Bug 1289505 Opened 3 years ago Closed 3 years ago

../../../../dist/include/nsStringAPI.h:1019: error: undefined reference to 'NS_CStringContainerInit'

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox50 fixed)

RESOLVED FIXED
Tracking Status
firefox50 --- fixed

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

Details

Attachments

(2 files)

49 bytes, text/x-github-pull-request
gerard-majax
: review+
Details | Review
58 bytes, text/x-review-board-request
gerard-majax
: review+
Details
Likely because of bug 1274540
Depends on: 1274540
This looks like a dupe of bug 1289381. Could you confirm?
Flags: needinfo?(lissyx+mozillians)
See Also: → 1289381
It is not exactly the same issue. Builds are currently with --enable-crashreporter.
Flags: needinfo?(lissyx+mozillians)
../../../../dist/include/nsStringAPI.h:1019: error: undefined reference to 'NS_CStringContainerInit'
../../../../../../../../../gecko-cinnabar/security/sandbox/linux/common/SandboxInfo.cpp:290: error: undefined reference to 'nsACString::AppendInt(int, int)'
../../../../dist/include/nsStringAPI.h:1081: error: undefined reference to 'NS_CStringContainerInit2'
../../../../../../../../../gecko-cinnabar/security/sandbox/linux/common/SandboxInfo.cpp:293: error: undefined reference to 'CrashReporter::AnnotateCrashReport(nsACString const&, nsACString const&)'
../../../../dist/include/nsStringAPI.h:1042: error: undefined reference to 'NS_CStringContainerFinish'
../../../../dist/include/nsStringAPI.h:1042: error: undefined reference to 'NS_CStringContainerFinish'
Attached file Gonk-misc PR
Assignee: nobody → lissyx+mozillians
Attachment #8774836 - Flags: review+
Depends on: 1289381
Comment on attachment 8774838 [details]
Bug 1289505 - Update gaia/gonk-misc repos

https://reviewboard.mozilla.org/r/67238/#review64152
Attachment #8774838 - Flags: review?(lissyx+mozillians) → review+
(In reply to Alexandre LISSY :gerard-majax from comment #4)
> ../../../../../../../../../gecko-cinnabar/security/sandbox/linux/common/
> SandboxInfo.cpp:290: error: undefined reference to
> 'nsACString::AppendInt(int, int)'
> ../../../../../../../../../gecko-cinnabar/security/sandbox/linux/common/
> SandboxInfo.cpp:293: error: undefined reference to
> 'CrashReporter::AnnotateCrashReport(nsACString const&, nsACString const&)'

Sorry; I should have caught this.  SandboxInfo is currently linked into libxul.so on desktop, so using libxul stuff directly happens to work, but it's in libmozsandbox.so on B2G (and might move back into libmozsandbox.so on desktop in the future).  This function really should live in libxul (see also security/sandbox/linux/glue); nothing that's simply reading the SandboxInfo flags actually needs to be a member of the SandboxInfo class.

And from a quick look at the code it looks like the SandboxInfo Telemetry integration should break the same way, but maybe I'm missing something?

In any case, if there's already an acceptable workaround for B2G then nothing in this comment necessarily needs to be acted on now, but someone (possibly me) is probably going to have to fix things at some point.
Well we disable crash reporter, it's easier for everyone.
https://hg.mozilla.org/mozilla-central/rev/05963fe43d95
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.