Closed Bug 1289506 Opened 5 years ago Closed 5 years ago

Close icon is off-centre

Categories

(DevTools :: Responsive Design Mode, defect, P2)

defect

Tracking

(firefox48 wontfix, firefox49 verified, firefox50 verified, firefox51 verified)

VERIFIED FIXED
Firefox 51
Tracking Status
firefox48 --- wontfix
firefox49 --- verified
firefox50 --- verified
firefox51 --- verified

People

(Reporter: ntim, Assigned: hholmes)

References

Details

Attachments

(2 files)

It's very visible in the responsive mode: https://bug1288897.bmoattachments.org/attachment.cgi?id=8774035
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
So this is more complicated than I thought, when making the close icon perfectly centered, it looks uneven in the toolbox.

Helen, maybe you can review the centering of those icons?
Assignee: ntim.bugs → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(hholmes)
Ended up bumping down the size of the 'x' by two pixels and recentering it—looks all right on my machine, but can you do a review, Tim?
Flags: needinfo?(hholmes)
Attachment #8778914 - Flags: review?(ntim.bugs)
Attachment #8778914 - Flags: review?(ntim.bugs) → review+
Thanks for taking a look!
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/deb1fab4b247
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Assignee: nobody → hholmes
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d5d53a3b4e50b94cdf85d20690526e5a00d5b63e&tochange=494289c72ba3997183e7b5beaca3e0447ecaf96d

mozregression says that this regressed in v48. Do we want to uplift this to DevEdition/Aurora at the least?
Flags: needinfo?(ntim.bugs)
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #8)
> https://hg.mozilla.org/mozilla-central/
> pushloghtml?fromchange=d5d53a3b4e50b94cdf85d20690526e5a00d5b63e&tochange=4942
> 89c72ba3997183e7b5beaca3e0447ecaf96d
> 
> mozregression says that this regressed in v48. Do we want to uplift this to
> DevEdition/Aurora at the least?

Yes, let's uplift this to DevEdition and Beta. Thanks for catching that!
Flags: needinfo?(ntim.bugs)
Attached patch Patch for betaSplinter Review
Approval Request Comment
[Feature/regressing bug #]: Bug 1225184
[User impact if declined]: off centre close icon in RDM
[Describe test coverage new/current, TreeHerder]: on m-c for 3 days
[Risks and why]: low, svg only change
[String/UUID change made/needed]: no
Attachment #8781263 - Flags: approval-mozilla-beta?
Comment on attachment 8778914 [details] [diff] [review]
Patch for m-c and Aurora

see comment 10 for approval request
Attachment #8778914 - Attachment description: close-icon.patch → Patch for m-c and Aurora
Attachment #8778914 - Flags: approval-mozilla-aurora?
Comment on attachment 8781263 [details] [diff] [review]
Patch for beta

Polish for the close icon, please uplift.
Attachment #8781263 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #8778914 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I have reproduced this bug with Nightly 50.0a1 (2016-07-26) on Ubuntu 14.04, 64 bit!

The bug's fix is now verified on latest Nightly 51.0a1, Aurora 50.0a2, Beta 49.0b6.


Nightly 51.0a1:
Build ID 	20160823072522
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0

Aurora 50.0a2:
Build ID 	20160824004001
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0

Beta 49.0b6:
Build ID 	20160822111414
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0
I have reproduced this bug with Nightly 50.0a1 (2016-07-26) on Ubuntu 14.04, 64 bit!

The bug's fix is now verified on latest Nightly 51.0a1, Aurora 50.0a2, Beta 49.0b6.


Nightly 51.0a1:
Build ID 	20160823072522
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0

Aurora 50.0a2:
Build ID 	20160824004001
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0

Beta 49.0b6:
Build ID 	20160822111414
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0

[bugday-20160824]
I have successfully reproduce this bug on firefox nightly 50.0a1 (2016-07-26)
with windows 7 (32 bit)
Mozilla/5.0 (Windows NT 6.1; rv:50.0) Gecko/20100101 Firefox/50.0

I found this fix on latest beta 49.0b5

Mozilla/5.0 (Windows NT 6.1; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID : 20160818050015

I found this fix on latest aurora 50.0a2 (2016-08-24)

Mozilla/5.0 (Windows NT 6.1; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID : 20160824004001

I found this fix on latest nightly 51.0a1 (2016-08-24)

Mozilla/5.0 (Windows NT 6.1; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID : 20160824030337
QA Whiteboard: [bugday-20160824]
Status: RESOLVED → VERIFIED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.