1289532 - Cannot access the new eyedropper directly from the Style Editor

Status: RESOLVED WONTFIX

(DevTools :: General, defect, P2)

Description

[magicp]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160623154057

Steps to reproduce:

1. Start Nightly
2. Go to any sites (e.g. about:home)
3. Open DevTools > Style Editor
4. Use eyedropper in the style editor


Actual results:

Cannot access the new eyedropper directly from the Style Editor

Regression range:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=e0bc88708ffed39aaab1fbc0ac461d93561195de&tochange=a7a882d122e36defe6c2a102a28ae7dfc16311c5


Expected results:

The eyedropper should be placed on a public access area. (e.g. on the toolbox toolbar)

Comment 1

[Brian Grinstead [:bgrins]]

We decided to move it to the inspector so it could be on by default there.  The eyedropper can still be accessed from the top level through Tools -> Web Developer -> Eyedropper (or from the wrench icon in the nav bar in dev edition)

Comment 2

[magicp]

(In reply to Brian Grinstead [:bgrins] from comment #1)
> We decided to move it to the inspector so it could be on by default there. 
> The eyedropper can still be accessed from the top level through Tools -> Web
> Developer -> Eyedropper (or from the wrench icon in the nav bar in dev
> edition)

This solution increases operational steps. How about pros cons of new position?

Comment 3

[Helen V. Holmes (:helenvholmes) (:✨)]

I'm going to mark this bug as a WONTFIX for a few reasons:

- We'd like to bring color editors into the Style Editor, which come with their own eyedropper. (See comment #16 in bug 1258390.)  This solution helps us from adding on to the "increasing number of buttons in toolbars until they lose meaning" issue we currently have.
- The new position also allows it to always be visible and on by default in the inspector (which is much more frequently used).

and lastly,
- It was off by default in the past on clean profiles, so for many it wasn't visible in the style editor in the first place.