Closed Bug 1289564 Opened 3 years ago Closed 3 years ago
Cacheability on http(s) scheme
58 bytes, text/x-review-board-request
Over in bug 1289163 it was originally hypothesized that the predictor was responsible for creating a bunch of empty cache entires on disk with nothing (not even metadata!) in them. While this was determined to not be the case, during investigation I noticed that the predictor is doing unnecessary work when updating cacheability - namely, it will open cache entries for URIs it doesn't make sense to open them for (about: is a popular scheme that we don't do any predictions for). I just forgot to add the IsNullOrHttp check in UpdateCacheability, let's add that.
Review commit: https://reviewboard.mozilla.org/r/67246/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/67246/
Attachment #8774859 - Flags: review?(honzab.moz)
Comment on attachment 8774859 [details] Bug 1289564 - Don't try to modify cacheability for non-http(s) resources. https://reviewboard.mozilla.org/r/67246/#review64186
Attachment #8774859 - Flags: review?(honzab.moz) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/acec32a2a176 Don't try to modify cacheability for non-http(s) resources. r=mayhemer
You need to log in before you can comment on or make changes to this bug.