Closed Bug 1289564 Opened 3 years ago Closed 3 years ago

Filter Predictor::UpdateCacheability on http(s) scheme

Categories

(Core :: Networking, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: u408661, Assigned: u408661)

Details

(Whiteboard: [necko-active])

Attachments

(1 file)

Over in bug 1289163 it was originally hypothesized that the predictor was responsible for creating a bunch of empty cache entires on disk with nothing (not even metadata!) in them. While this was determined to not be the case, during investigation I noticed that the predictor is doing unnecessary work when updating cacheability - namely, it will open cache entries for URIs it doesn't make sense to open them for (about: is a popular scheme that we don't do any predictions for). I just forgot to add the IsNullOrHttp check in UpdateCacheability, let's add that.
Comment on attachment 8774859 [details]
Bug 1289564 - Don't try to modify cacheability for non-http(s) resources.

https://reviewboard.mozilla.org/r/67246/#review64186
Attachment #8774859 - Flags: review?(honzab.moz) → review+
Pushed by hurley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/acec32a2a176
Don't try to modify cacheability for non-http(s) resources. r=mayhemer
https://hg.mozilla.org/mozilla-central/rev/acec32a2a176
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.