Closed Bug 1289589 Opened 8 years ago Closed 8 years ago

Edit button shows up when user doesn't have edit permission for a page

Categories

(developer.mozilla.org Graveyard :: Editing, defect)

All
Other
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: francois, Unassigned, Mentored)

Details

(Keywords: in-triage, Whiteboard: [specification][type:bug])

What did you do?
================
1. Open https://developer.mozilla.org/en-US/docs/Template:Spec2 with a normal account.
2. Look in the top right corner.

What happened?
==============
I see the "Edit" button and I get a "Permission Denied" page.

What should have happened?
==========================
The "Edit" button should not be there if I don't have the right permissions.

Is there anything else we should know?
======================================
Mentor: jwhitlock
Keywords: in-triage
Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/3dd4a86c2d09761749db4b694fa602220ef26340
bug 1289589: Cleanup template code

Remove an unnecessary </li> that must have been leftover from a previous
cleanup.

https://github.com/mozilla/kuma/commit/901fc4c1c62e5996591147a2132e7014bee468ad
fix bug 1289589: Remove edit button from templates

If the user doesn't have permission to edit templates, don't show the
edit button.

https://github.com/mozilla/kuma/commit/ac827d16246b984c6bcecdff293fb20a75d497bf
Merge pull request #3919 from MatonAnthony/bug-1289589

Fix bug 1289589 : Remove edit button from templates if the user cannot edit them
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.