1289598 - 800 instances of "Hardware Vsync support not yet implemented. Falling back to software timers" emitted from gfx/thebes/gfxPlatform.cpp during linux64 debug testing

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Eric Rahm [:erahm]]

> 779 WARNING: Hardware Vsync support not yet implemented. Falling back to software timers: file gfx/thebes/gfxPlatform.cpp, line 2267

This warning [1] shows up in the following test suites:

>     37 - desktop-test-linux64/debug-mochitest-chrome-1 c1
>     35 - desktop-test-linux64/debug-mochitest-chrome-3 c3
>     30 - desktop-test-linux64/debug-mochitest-clipboard cl
>     28 - desktop-test-linux64/debug-mochitest-clipboard-e10s cl
>     27 - desktop-test-linux64/debug-mochitest-chrome-2 c2
>     19 - desktop-test-linux64/debug-mochitest-browser-chrome-e10s-4 bc4
>     18 - desktop-test-linux64/debug-mochitest-browser-chrome-e10s-2 bc2
>     18 - desktop-test-linux64/debug-mochitest-browser-chrome-e10s-1 bc1
>     17 - desktop-test-linux64/debug-mochitest-5 5
>     17 - desktop-test-linux64/debug-mochitest-browser-chrome-e10s-3 bc3
>     17 - desktop-test-linux64/debug-mochitest-browser-chrome-e10s-5 bc5
>     17 - desktop-test-linux64/debug-mochitest-browser-chrome-6 bc6
>     16 - desktop-test-linux64/debug-mochitest-e10s-5 5
>     16 - desktop-test-linux64/debug-mochitest-browser-chrome-2 bc2
>     16 - desktop-test-linux64/debug-mochitest-browser-chrome-5 bc5
>     15 - desktop-test-linux64/debug-mochitest-browser-chrome-3 bc3
>     15 - desktop-test-linux64/debug-mochitest-3 3
>     14 - desktop-test-linux64/debug-mochitest-e10s-3 3
>     14 - desktop-test-linux64/debug-mochitest-9 9
>     14 - desktop-test-linux64/debug-mochitest-e10s-9 9
>     14 - desktop-test-linux64/debug-mochitest-10 10
>     14 - desktop-test-linux64/debug-mochitest-8 8
>     14 - desktop-test-linux64/debug-mochitest-browser-chrome-1 bc1
>     13 - desktop-test-linux64/debug-mochitest-e10s-4 4
>     13 - desktop-test-linux64/debug-mochitest-1 1
>     13 - desktop-test-linux64/debug-mochitest-7 7
>     13 - desktop-test-linux64/debug-mochitest-4 4
>     13 - desktop-test-linux64/debug-mochitest-e10s-2 2
>     13 - desktop-test-linux64/debug-mochitest-e10s-8 8
>     13 - desktop-test-linux64/debug-mochitest-e10s-1 1
>     13 - desktop-test-linux64/debug-mochitest-e10s-7 7
>     13 - desktop-test-linux64/debug-mochitest-6 6
>     13 - desktop-test-linux64/debug-mochitest-2 2
>     13 - desktop-test-linux64/debug-mochitest-e10s-10 10
>     12 - desktop-test-linux64/debug-mochitest-browser-chrome-4 bc4
>     12 - desktop-test-linux64/debug-mochitest-e10s-6 6
>      9 - desktop-test-linux64/debug-mochitest-media mda
>      9 - desktop-test-linux64/debug-mochitest-media-e10s mda
>      7 - desktop-test-linux64/debug-mochitest-gpu gpu
>      7 - desktop-test-linux64/debug-mochitest-gpu-e10s gpu
>      7 - desktop-test-linux64/debug-mochitest-devtools-chrome-7 dt7
>      6 - desktop-test-linux64/debug-mochitest-devtools-chrome-5 dt5
>      5 - desktop-test-linux64/debug-mochitest-webgl-e10s gl
>      5 - desktop-test-linux64/debug-mochitest-devtools-chrome-3 dt3
>      5 - desktop-test-linux64/debug-mochitest-webgl gl
>      4 - desktop-test-linux64/debug-mochitest-devtools-chrome-4 dt4
>      4 - desktop-test-linux64/debug-firefox-ui-functional-remote en-US
>      4 - desktop-test-linux64/debug-mochitest-devtools-chrome-2 dt2
>      4 - desktop-test-linux64/debug-web-platform-tests-5 5
>      4 - desktop-test-linux64/debug-web-platform-tests-e10s-5 5
>      3 - desktop-test-linux64/debug-web-platform-tests-e10s-7 7
>      3 - desktop-test-linux64/debug-mochitest-devtools-chrome-1 dt1
>      3 - desktop-test-linux64/debug-firefox-ui-functional-remote-e10s en-US
>      3 - desktop-test-linux64/debug-mochitest-devtools-chrome-6 dt6
>      3 - desktop-test-linux64/debug-mochitest-devtools-chrome-8 dt8
>      3 - desktop-test-linux64/debug-web-platform-tests-7 7
>      2 - desktop-test-linux64/debug-web-platform-tests-reftests-e10s Wr
>      2 - desktop-test-linux64/debug-web-platform-tests-reftests Wr
>      1 - desktop-test-linux64/debug-web-platform-tests-e10s-10 10
>      1 - desktop-test-linux64/debug-reftest-7 R7
>      1 - desktop-test-linux64/debug-reftest-no-accel-8 Ru8
>      1 - desktop-test-linux64/debug-web-platform-tests-2 2
>      1 - desktop-test-linux64/debug-crashtest-e10s C
>      1 - desktop-test-linux64/debug-firefox-ui-functional-local-e10s en-US
>      1 - desktop-test-linux64/debug-reftest-no-accel-e10s-8 Ru8
>      1 - desktop-test-linux64/debug-gtest GTest
>      1 - desktop-test-linux64/debug-web-platform-tests-6 6
>      1 - desktop-test-linux64/debug-reftest-no-accel-2 Ru2
>      1 - desktop-test-linux64/debug-reftest-5 R5
>      1 - desktop-test-linux64/debug-reftest-no-accel-e10s-3 Ru3
>      1 - desktop-test-linux64/debug-reftest-e10s-8 R8
>      1 - desktop-test-linux64/debug-web-platform-tests-e10s-2 2
>      1 - desktop-test-linux64/debug-mochitest-a11y a11y
>      1 - desktop-test-linux64/debug-reftest-no-accel-6 Ru6
>      1 - desktop-test-linux64/debug-jsreftest-2 J2
>      1 - desktop-test-linux64/debug-web-platform-tests-e10s-6 6
>      1 - desktop-test-linux64/debug-reftest-e10s-5 R5
>      1 - desktop-test-linux64/debug-mochitest-browser-chrome-7 bc7
>      1 - desktop-test-linux64/debug-reftest-e10s-3 R3
>      1 - desktop-test-linux64/debug-reftest-e10s-1 R1
>      1 - desktop-test-linux64/debug-firefox-ui-functional-local en-US
>      1 - desktop-test-linux64/debug-web-platform-tests-e10s-12 12
>      1 - desktop-test-linux64/debug-web-platform-tests-1 1
>      1 - desktop-test-linux64/debug-reftest-e10s-7 R7
>      1 - desktop-test-linux64/debug-reftest-e10s-6 R6
>      1 - desktop-test-linux64/debug-reftest-no-accel-e10s-7 Ru7
>      1 - desktop-test-linux64/debug-reftest-no-accel-e10s-5 Ru5
>      1 - desktop-test-linux64/debug-jsreftest-e10s-2 J2
>      1 - desktop-test-linux64/debug-reftest-2 R2
>      1 - desktop-test-linux64/debug-reftest-6 R6
>      1 - desktop-test-linux64/debug-web-platform-tests-e10s-1 1
>      1 - desktop-test-linux64/debug-reftest-no-accel-e10s-2 Ru2
>      1 - desktop-test-linux64/debug-web-platform-tests-9 9
>      1 - desktop-test-linux64/debug-reftest-no-accel-7 Ru7
>      1 - desktop-test-linux64/debug-reftest-e10s-4 R4
>      1 - desktop-test-linux64/debug-reftest-no-accel-3 Ru3
>      1 - desktop-test-linux64/debug-reftest-no-accel-e10s-4 Ru4
>      1 - desktop-test-linux64/debug-web-platform-tests-12 12
>      1 - desktop-test-linux64/debug-web-platform-tests-e10s-4 4
>      1 - desktop-test-linux64/debug-reftest-8 R8
>      1 - desktop-test-linux64/debug-reftest-no-accel-e10s-1 Ru1
>      1 - desktop-test-linux64/debug-mochitest-devtools-chrome-10 dt10
>      1 - desktop-test-linux64/debug-jsreftest-e10s-1 J1
>      1 - desktop-test-linux64/debug-mochitest-browser-chrome-e10s-7 bc7
>      1 - desktop-test-linux64/debug-web-platform-tests-4 4
>      1 - desktop-test-linux64/debug-mochitest-jetpack JP
>      1 - desktop-test-linux64/debug-reftest-1 R1
>      1 - desktop-test-linux64/debug-web-platform-tests-11 11
>      1 - desktop-test-linux64/debug-web-platform-tests-e10s-9 9
>      1 - desktop-test-linux64/debug-reftest-no-accel-5 Ru5
>      1 - desktop-test-linux64/debug-reftest-no-accel-1 Ru1
>      1 - desktop-test-linux64/debug-mochitest-browser-chrome-e10s-6 bc6
>      1 - desktop-test-linux64/debug-reftest-e10s-2 R2
>      1 - desktop-test-linux64/debug-web-platform-tests-3 3
>      1 - desktop-test-linux64/debug-web-platform-tests-e10s-8 8
>      1 - desktop-test-linux64/debug-reftest-no-accel-e10s-6 Ru6
>      1 - desktop-test-linux64/debug-web-platform-tests-8 8
>      1 - desktop-test-linux64/debug-web-platform-tests-e10s-11 11
>      1 - desktop-test-linux64/debug-reftest-4 R4
>      1 - desktop-test-linux64/debug-web-platform-tests-10 10
>      1 - desktop-test-linux64/debug-reftest-no-accel-4 Ru4
>      1 - desktop-test-linux64/debug-reftest-3 R3
>      1 - desktop-test-linux64/debug-crashtest C
>      1 - desktop-test-linux64/debug-mochitest-devtools-chrome-9 dt9
>      1 - desktop-test-linux64/debug-jsreftest-1 J1
>      1 - desktop-test-linux64/debug-web-platform-tests-e10s-3 3

It shows up in 104 tests. A few of the most prevalent:

>    378 -        Shutdown
>    251 - [e10s] Shutdown
>      2 - [e10s] test_safe_browsing_initial_download.py TestSafeBrowsingInitialDownload.test_safe_browsing_initial_download
>      2 -        test_safe_browsing_initial_download.py TestSafeBrowsingInitialDownload.test_safe_browsing_initial_download
>      1 - [e10s] /webgl/conformance-1.0.3/conformance/uniforms/uniform-values-per-program.html
>      1 -        toolkit/content/tests/browser/browser_content_url_annotation.js
>      1 -        dom/imptests/html/webgl/test_compressedTexSubImage2D.html
>      1 -        devtools/client/debugger/test/mochitest/browser_dbg_variables-view-popup-14.js
>      1 -        /html/the-xhtml-syntax/parsing-xhtml-documents/xhtml-mathml-dtd-entity-support.htm
>      1 -        widget/tests/test_bug565392.html

[1] https://hg.mozilla.org/mozilla-central/annotate/81e206ee8ba7/gfx/thebes/gfxPlatform.cpp#l2267

Comment 1

[Eric Rahm [:erahm]]

This warning was introduced 2 years ago in bug 1102631. We should probably just remove it or make it a log message. Mason I'm happy to do either, what do you think?

Comment 2

[Eric Rahm [:erahm]]

Attachment: Remove warning about software vsync

Comment 3

[Mason Chang [Inactive] [:mchang]]

Hmm this is odd, I thought we had hardware vsync on linux. Or does that not work on try?

Comment 4

[Eric Rahm [:erahm]]

(In reply to Mason Chang [:mchang] from comment #3)
> Hmm this is odd, I thought we had hardware vsync on linux. Or does that not
> work on try?

Bug 1102631, comment 0 indicates:

> This is also useful fortests.

So yeah, maybe a try thing since they're in VMs? I can confirm I *don't* see the warning on my Ubuntu 14.04 machine.

Comment 5

[Mason Chang [Inactive] [:mchang]]

(In reply to Eric Rahm [:erahm] from comment #4)
> (In reply to Mason Chang [:mchang] from comment #3)
> > Hmm this is odd, I thought we had hardware vsync on linux. Or does that not
> > work on try?
> 
> Bug 1102631, comment 0 indicates:
> 
> > This is also useful fortests.
> 
> So yeah, maybe a try thing since they're in VMs? I can confirm I *don't* see
> the warning on my Ubuntu 14.04 machine.

Alright cool thanks, yeah it's probably because they are VMs.

Comment 6

[Andrew Comminos [:acomminos]]

Bit late here, but I can confirm that the test slaves lack hardware accelerated GL, and llvmpipe (as a hardware independent userspace backend) does not support SGI_video_sync.

Comment 7

[Eric Rahm [:erahm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/38583e7686b7a283daf83b30f29eb47bd1fc36a0
Bug 1289598 - Remove warning about software vsync. r=mchang

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/38583e7686b7