1289614 - 900 instances of "TabChild::SetFocus not supported in TabChild" emitted from dom/ipc/TabChild.cpp during linux64 debug testing

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Eric Rahm [:erahm]]

> 939 WARNING: TabChild::SetFocus not supported in TabChild: file dom/ipc/TabChild.cpp, line 1092

This warning [1] shows up in the following test suites:

>    181 - desktop-test-linux64/debug-mochitest-e10s-9 9
>    114 - desktop-test-linux64/debug-mochitest-clipboard-e10s cl
>     85 - desktop-test-linux64/debug-mochitest-e10s-3 3
>     50 - desktop-test-linux64/debug-mochitest-e10s-5 5
>     47 - desktop-test-linux64/debug-mochitest-e10s-7 7
>     44 - desktop-test-linux64/debug-mochitest-e10s-8 8
>     39 - desktop-test-linux64/debug-mochitest-e10s-2 2
>     35 - desktop-test-linux64/debug-mochitest-browser-chrome-e10s-5 bc5
>     29 - desktop-test-linux64/debug-mochitest-e10s-1 1
>     28 - desktop-test-linux64/debug-mochitest-e10s-10 10
>     26 - desktop-test-linux64/debug-mochitest-e10s-4 4
>     26 - desktop-test-linux64/debug-mochitest-e10s-6 6
>     22 - desktop-test-linux64/debug-mochitest-browser-chrome-e10s-4 bc4
>     19 - desktop-test-linux64/debug-mochitest-browser-chrome-e10s-1 bc1
>     18 - desktop-test-linux64/debug-mochitest-media-e10s mda
>     18 - desktop-test-linux64/debug-mochitest-browser-chrome-e10s-2 bc2
>     17 - desktop-test-linux64/debug-firefox-ui-functional-local-e10s en-US
>     17 - desktop-test-linux64/debug-mochitest-browser-chrome-e10s-3 bc3
>     14 - desktop-test-linux64/debug-firefox-ui-functional-remote-e10s en-US
>     13 - desktop-test-linux64/debug-mochitest-clipboard cl
>     11 - desktop-test-linux64/debug-mochitest-gpu-e10s gpu
>     10 - desktop-test-linux64/debug-reftest-no-accel-e10s-3 Ru3
>     10 - desktop-test-linux64/debug-mochitest-webgl-e10s gl
>      9 - desktop-test-linux64/debug-reftest-no-accel-e10s-8 Ru8
>      9 - desktop-test-linux64/debug-reftest-e10s-3 R3
>      9 - desktop-test-linux64/debug-reftest-e10s-8 R8
>      7 - desktop-test-linux64/debug-mochitest-browser-chrome-e10s-7 bc7
>      6 - desktop-test-linux64/debug-reftest-e10s-5 R5
>      6 - desktop-test-linux64/debug-mochitest-chrome-3 c3
>      6 - desktop-test-linux64/debug-reftest-no-accel-e10s-5 Ru5
>      5 - desktop-test-linux64/debug-crashtest-e10s C
>      2 - desktop-test-linux64/debug-web-platform-tests-e10s-9 9
>      1 - desktop-test-linux64/debug-mochitest-browser-chrome-e10s-6 bc6
>      1 - desktop-test-linux64/debug-reftest-e10s-4 R4
>      1 - desktop-test-linux64/debug-reftest-no-accel-e10s-4 Ru4
>      1 - desktop-test-linux64/debug-reftest-e10s-2 R2
>      1 - desktop-test-linux64/debug-reftest-e10s-1 R1
>      1 - desktop-test-linux64/debug-reftest-no-accel-e10s-7 Ru7
>      1 - desktop-test-linux64/debug-reftest-no-accel-e10s-6 Ru6

It shows up in 305 tests. A few of the most prevalent:

>    246 - [e10s] Shutdown
>    143 - [e10s] layout/base/tests/test_reftests_with_caret.html
>     38 - [e10s] dom/html/test/test_fullscreen-api.html
>     31 - [e10s] editor/libeditor/tests/test_bug520189.html
>     22 - [e10s] dom/tests/mochitest/pointerlock/test_pointerlock-api.html
>     18 - [e10s] editor/libeditor/tests/test_bug478725.html
>     13 - [e10s] dom/tests/mochitest/bugs/test_bug369306.html
>     13 -        toolkit/content/tests/chrome/test_findbar.xul
>     13 - [e10s] toolkit/content/tests/chrome/test_findbar.xul
>      8 - [e10s] editor/libeditor/tests/test_bug525389.html

[1] https://hg.mozilla.org/mozilla-central/annotate/81e206ee8ba7/dom/ipc/TabChild.cpp#l1092

Comment 1

[Eric Rahm [:erahm]]

Olli, it looks like you changed this from NOT_REACHED to a WARNING in bug 917026. Do you think it's still useful as a warning?

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Based on my comment https://bugzilla.mozilla.org/show_bug.cgi?id=917026#c8
removing the warning should be ok.

Also removing the warning from ::Blur should be fine.

r=me if you want to land the change

Comment 3

[Eric Rahm [:erahm]]

Attachment: Remove warnings from TabChild::{SetFocus,Blur}

Comment 4

[Eric Rahm [:erahm]]

Comment on attachment 8775254 [details] [diff] [review]
Remove warnings from TabChild::{SetFocus,Blur}

Carrying forward r+ from comment 2.

Comment 5

[Eric Rahm [:erahm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/60d7601e512787e8265f0c3ed52e67517a857b58
Bug 1289614 - Remove warnings from TabChild::{SetFocus,Blur}. r=smaug

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/60d7601e5127