Closed Bug 1289624 Opened 3 years ago Closed 3 years ago

Clear servo node data when nodes are removed from the tree

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(2 files)

I wrote a patch for this at some point, might as well get it in the tree. There's no point in holding onto node data at this point, since we'll need to recompute it all when the node gets reinserted.
Attachment #8774941 - Flags: review?(cam) → review+
Attachment #8774942 - Flags: review?(cam) → review+
Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6956d996b229
Switch to UniquePtr for managing ServoNodeData. r=heycam
https://hg.mozilla.org/integration/mozilla-inbound/rev/b7da49e9a645
Clear servo data when nodes are removed from the tree. r=heycam
https://hg.mozilla.org/mozilla-central/rev/6956d996b229
https://hg.mozilla.org/mozilla-central/rev/b7da49e9a645
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Blocks: stylo-incremental
No longer blocks: stylo
You need to log in before you can comment on or make changes to this bug.