Closed
Bug 1289624
Opened 8 years ago
Closed 8 years ago
Clear servo node data when nodes are removed from the tree
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(2 files)
|
6.69 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
|
1.81 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
I wrote a patch for this at some point, might as well get it in the tree. There's no point in holding onto node data at this point, since we'll need to recompute it all when the node gets reinserted.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8774941 -
Flags: review?(cam)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Attachment #8774942 -
Flags: review?(cam)
|
||
Updated•8 years ago
|
Attachment #8774941 -
Flags: review?(cam) → review+
|
|
||
Updated•8 years ago
|
Attachment #8774942 -
Flags: review?(cam) → review+
Pushed by bholley@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6956d996b229 Switch to UniquePtr for managing ServoNodeData. r=heycam https://hg.mozilla.org/integration/mozilla-inbound/rev/b7da49e9a645 Clear servo data when nodes are removed from the tree. r=heycam
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6956d996b229 https://hg.mozilla.org/mozilla-central/rev/b7da49e9a645
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
|
|
Assignee | |
Updated•8 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•