Autoland warns of changes that, in fact, don't exist

NEW
Unassigned

Status

MozReview
Review Board: User Interface
2 years ago
2 years ago

People

(Reporter: glandium, Unassigned)

Tracking

Details

(Reporter)

Description

2 years ago
On bug 1289289, I updated the commit message before autolanding, without changes to the code. Even though I also happen to have rebased, the interdiff reviewboard shows is also empty.

In this case, I think it shouldn't warn that there were changes before autolanding.

Comment 1

2 years ago
This is likely something that needs to be done at commit submit time, since determining whether 2 commits are identical isn't a trivial problem (and I don't trust Review Board to make that decision by looking at diffs). I'd rather have Mercurial compare manifests for files changed in the reviewed changesets and then upload metadata as part of creating the review requests.

smacleod may have another opinion.
(Reporter)

Comment 2

2 years ago
Considering review requests are still created by clients, I don't think this is a good idea. For one, this means that would need to be done for both git and mercurial.

Comment 3

2 years ago
(In reply to Mike Hommey [:glandium] from comment #2)
> Considering review requests are still created by clients, I don't think this
> is a good idea. For one, this means that would need to be done for both git
> and mercurial.

Nope.

The client makes an HTTP POST to the Mercurial server which then talks to MozReview. The code is at https://hg.mozilla.org/hgcustom/version-control-tools/file/cf8f74b3783c/hgext/reviewboard/hgrb/proto.py#l195.

This abstraction allows us to roll out improvements like this without client cooperation.
Component: Autoland → Review Board: User Interface
You need to log in before you can comment on or make changes to this bug.