128965 - Need 16x16 icons for components

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect)

Description

[jag (Peter Annema)]

For bug 128959, bug 128960, bug 128964.

Comment 1

[timeless]

no art until you get mozilla.org to fix licensing.

talk to mitchell :-)

Comment 2

[Ian Pottinger]

adding self to cc list

Comment 3

[Matthias Versen [:Matti]]

*** Bug 136415 has been marked as a duplicate of this bug. ***

Comment 4

[Vadim Berezniker]

*** Bug 136772 has been marked as a duplicate of this bug. ***

Comment 5

[Asa Dotzler [:asa]]

I'm not sure what timeless is talking about but we do need to replace the icons
in the Window menu with ones that aren't stretched before RC1 or we need to back
out that change (bug 128959). This will certainly be one of the most duplicated
bugs filed on RC1 if it's allowed out the door. I intend to not allow it out the
door with this half-implemented change to the Window menu. RC1 will be ready to
go in days and not weeks so if we plan on keeping this feature in for RC1 then
we need new icons.

Comment 6

[Dac Chartrand]

Icons in window menu are horrible. Everyone will notice. 

Remove them or fix them. This bug should have a higher priority.

Comment 7

[Shark Daddy (Jonathan L.)]

*** Bug 137245 has been marked as a duplicate of this bug. ***

Comment 8

[Markus Gerstel]

Comment 5 : '..but we do need to replace the icons in the Window menu with ones
that aren't stretched before RC1 or we need to back out that change (bug 128959).'

Sounds like a blocker to me.

Comment 9

[Andreas Premstaller]

Attachment: Set of 16x16-icons for modern

Here are icons for modern: navigator, mail, composer and addressbook. Based on
the original ones, size and some cackground transparencies corrected.

Comment 10

[Andreas Premstaller]

Attachment: same icons in the same zip file

zip file is no patch, obviously. Sorry for the spam.

Comment 11

[Andreas Premstaller]

Attachment: Screenshot modern with new icons

Comment 12

[Andreas Premstaller]

Attachment: zip-file containing 4 16x16-icons for classic

Here is a set of 16x16-icons for classic: navigator, mail, composer and
addressbook. Again, based on the original ones, size changed to 16x16.

Comment 13

[Andreas Premstaller]

Attachment: And finally a screenshot for classic with the "new" icons.

Comment 14

[Andreas Premstaller]

marlon, will you please take a look at the icons? 
Chatzilla probably needs some more changes.

Comment 15

[Andreas Premstaller]

I tried to add an icon for chatzilla, here is my problem:

in chatzillaOverlay.xul, I added 
        class="menuitem-iconic icon-chatzilla16 menu-iconic"
to the <menuitem> in <menupopup id="windowPopup">.

In chatzilla.css, I added a class
.icon-chatzilla16 {
  list-style-image: url("chrome://chatzilla/skin/images/chatzilla-16.gif"); }

However, the icon does not show up, I presume because chatzilla.css is only
loaded when chatzilla is actually invoked.
The taskbar-icon for chatzilla is defined directly in chatzillaOverlay.xul
(like this: image="chrome://chatzilla/skin/images/chatzilla-16.gif").

Is there a possibility to add the information about the icon directly in
chatzillaOverlay.xul, or some other place that is read at startup, and if yes,
where?

Comment 16

[Andreas Premstaller]

Attachment: 16x16-icon for chatzilla

Not yet build in, but if needed in the future, it is here.

Comment 17

[Robert Kaiser]

Andreas:
To specify it directly in chatzillaOverlay.xul would/could break alternative
skins for chatzilla.
The right way to do that is to add a chatzillaOverlay.css file and link it from
chatzillaOverlay.xul

Look into calendar for a good example!

Comment 18

[marlon bishop]

those icons are good, thanks.. the only thing i would suggest based on that
screenshot is to middle align the icon with the menu text.

Comment 19

[Andreas Premstaller]

Attachment: zip-file containing 4 16x16-icons for modern, revised

icons for navigator, mail, composer, addressbook for modern. Centered
vertically with the menu text.

Comment 20

[Andreas Premstaller]

Attachment: zip-file containing 4 16x16-icons for classic

Same as above, revised for vertical alignment

Comment 21

[Andreas Premstaller]

Attachment: Screenshot modern

Comment 22

[Andreas Premstaller]

Attachment: Finally, screenshot for classic, revised icons

Comment 23

[marlon bishop]

looks great, thanks again

Comment 24

[Jaime Rodriguez, Jr.]

adt1.0.0+ (on ADT's behalf) for checkin into the 1.0 branch. Pls check this in
to the branch today. After it is checked in, pls add fixed1.0.0. Once QA has
verified it on the branch, then add verified1.0.0.

Comment 25

[Andreas Premstaller]

marlon, can you provide for checkin into the branch. Who is going to review this
change?

Comment 26

[timeless]

are you sure attachment 79336 [details] contains modern icons?

Comment 27

[Andreas Premstaller]

Pretty sure. Just checked again by downloading from bugzilla: attachment 79336 [details]
are modern, attachment 79338 [details] are classic icons.

Comment 28

[Alex Bishop]

> Pretty sure. Just checked again by downloading from bugzilla: attachment 79336 [details]
> are modern, attachment 79338 [details] are classic icons.

That's what I get.

Comment 29

[jag (Peter Annema)]

Assuming r=marlon, sr=jag.

Comment 30

[Scott Collins]

<jag says...> checked in on the branch and trunk.  marking accordingly.

Comment 31

[Patty Mac]

verified on linux and windows 98 mozilla branch build (2002-04-25-08-1.0.0)
and commercial trunk (2002-04-25-12-TRUNK)