1289659 - [OS X] Firefox Nightly 50.0a1 shows no "Bookmarks Menu" contents when no windows opened.

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Eiichi]

Attachment: Screen Shot.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20160726080520

Steps to reproduce:

Close all windows or all tabs.


Actual results:

When I click Bookmarks menu, Bookmarks menu shows no "Bookmarks Menu" contents.


Expected results:

"Bookmarks Menu" contents should be shown.

Comment 1

[Tooru Fujisawa [:arai]]

Regression range:
  https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=70b3e6ac383941005652196f432d9134dea468a7&tochange=f98e3add979e3b2eba6461fdaed2cfc80961ff6f

apparently a regression from bug 1248268.

When I open the "bookmarks" menu without any window, the following error is thrown:

> TypeError: placesContextMenu is null
> browser-places.js:1429:5

https://dxr.mozilla.org/mozilla-central/rev/ceb63dec9267e9bb62f5e5e1f4c9d32d3ac1fbac/browser/base/content/browser-places.js#1429
>     placesContextMenu.addEventListener("popupshowing", onPlacesContextMenuShowing);

Comment 2

[Justin Dolske [:Dolske]]

Dao, can you look at this since the regressing bug was yours?

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch

Comment 4

[Mike de Boer [:mikedeboer]]

Comment on attachment 8779701 [details] [diff] [review]
patch

Review of attachment 8779701 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7db46aeeaf03
Account for placesContext not existing in non-browser windows on Mac. r=mdeboer

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7db46aeeaf03

Comment 7

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Can you request uplift? Looks like a regression from 49 and we could still uplift this for beta 4.

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 8779701 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 1248268
[User impact if declined]: see comment 0
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: just a null check, super-low risk
[String/UUID change made/needed]: none

Comment 9

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Comment on attachment 8779701 [details] [diff] [review]
patch

Fix for bookmark regression in 49.  Please uplift to aurora and beta.

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/024841102fac

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/9502c95c7c9b

Comment 12

[Kazi Nuzhat Tasnem]

I have reproduced this bug with Firefox nightly 50.0a1(build id:20160726080520)on
windows 7(64 bit)

I have verified this bug fixed with Firefox nightly 51.0a1(build id:20160822064441)
User Agent:Mozilla/5.0 (Windows NT 6.1; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0

[bugday-20160824]

Comment 13

[Dão Gottwald [:dao]]

Thanks!

Comment 14

[Camelia Badau [:cbadau], Desktop Test Engineering]

Verified fixed on latest Nightly 51.0a1 (buildID: 20160828030602), latest Aurora 50.0a2 (buildID: 20160828004009) and Firefox 49 Beta 7 (buildID: 20160825132718).