Closed Bug 1289672 Opened 8 years ago Closed 8 years ago

Unused nsPluginHost.mPluginsClickToPlay member.

Categories

(Core Graveyard :: Plug-ins, defect, P3)

defect

Tracking

(firefox50 affected, firefox51 fixed)

RESOLVED FIXED
mozilla51
Tracking Status
firefox50 --- affected
firefox51 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(1 file)

The usage of nsPluginHost.mPluginsClickToPlay was removed by bug 875454.

https://hg.mozilla.org/mozilla-central/rev/5ef49706a56a
> -  if ((mPluginsClickToPlay && plugin->IsClicktoplay()) ||


but we're still getting and monitoring the pref.

https://dxr.mozilla.org/mozilla-central/rev/ceb63dec9267e9bb62f5e5e1f4c9d32d3ac1fbac/dom/plugins/base/nsPluginHost.cpp#307
> nsPluginHost::nsPluginHost()
> ...
> {
> ...
>   mPluginsClickToPlay = Preferences::GetBool("plugins.click_to_play", false);
> ...
>   Preferences::AddStrongObserver(this, "plugins.click_to_play");

https://dxr.mozilla.org/mozilla-central/rev/ceb63dec9267e9bb62f5e5e1f4c9d32d3ac1fbac/dom/plugins/base/nsPluginHost.cpp#3627
> NS_IMETHODIMP nsPluginHost::Observe(nsISupports *aSubject,
>                                     const char *aTopic,
>                                     const char16_t *someData)
> {
> ...
>     mPluginsClickToPlay = Preferences::GetBool("plugins.click_to_play", false);

At least getting the pref value shouldn't be necessary.
Can we remove it?
The variable and all the machinery related to it in nsPluginHost can be removed.
Priority: -- → P3
Removed codes related to plugins.click_to_play from nsPluginHost.cpp

Green on try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=64fc17bfd7de
Assignee: nobody → arai.unmht
Attachment #8783895 - Flags: review?(benjamin)
Comment on attachment 8783895 [details] [diff] [review]
Remove unused nsPluginHost.mPluginsClickToPlay and observation for plugins.click_to_play.

Thank you!
Attachment #8783895 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/564fb56f56678aa39fde040fae60c3a190b686ca
Bug 1289672 - Remove unused nsPluginHost.mPluginsClickToPlay and observation for plugins.click_to_play. r=bsmedberg
https://hg.mozilla.org/mozilla-central/rev/564fb56f5667
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: