128970 - cycleView does not cycle in the ViewsArray.

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[TANAKA Satoshi]

To cycle in "client.viewsArray", change the function,

function cycleView (amount)
{
    var len = client.viewsArray.length;
    if (len <= 1)
        return;
    
    var tb = getTabForObject (client.currentObject);
    if (!tb)
        return;
    
    var vk = Number(tb.getAttribute("viewKey"));
    var destKey = (vk + amount) % len; /* wrap around */

    setCurrentObject (client.viewsArray[destKey].source);
}

Comment 1

[mental]

The rewrite looks logically identical to what you have...  patch incoming.

Comment 2

[mental]

Attachment: above changes

Comment 3

[Robert Ginda]

Comment on attachment 72555 [details] [diff] [review]
above changes

r=rginda

Comment 4

[Samuel Sieb]

checked in