1289764 - Move gHPanedWidget/gVPanedWidget to WidgetCache

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

Let's move other widgets to WidgetCache and use them in other widget code.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: patch

There's a patch for it, Thanks!
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=87a0051627d8

Comment 2

[Andrew Comminos [:acomminos]]

Comment on attachment 8775293 [details] [diff] [review]
patch

Review of attachment 8775293 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, just one thing;

::: widget/gtk/WidgetStyleCache.cpp
@@ +542,5 @@
> +                                     GTK_STYLE_CLASS_PANE_SEPARATOR);
> +    case MOZ_GTK_SPLITTER_SEPARATOR_VERTICAL:
> +      // TODO - create from CSS node
> +      return GetWidgetStyleWithClass(MOZ_GTK_SPLITTER_VERTICAL,
> +                                     GTK_STYLE_CLASS_PANE_SEPARATOR);

Since "separator" is a proper subnode of "paned", can we get that subnode here instead with CreateChildCSSNode?

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: patch for check-in

Thanks, there's the one with CreateChildCSSNode().
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b1451b337255

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8775947 [details] [diff] [review]
patch for check-in

btw. It needs landed patch from Bug 1288413 before check-in.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/60a5e5073e1f
Move gHPanedWidget/gVPanedWidget to WidgetCache, r=acomminos

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/60a5e5073e1f