Move gHPanedWidget/gVPanedWidget to WidgetCache

RESOLVED FIXED in Firefox 51

Status

()

Core
Widget: Gtk
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: stransky, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
mozilla51
x86_64
Linux
Points:
---

Firefox Tracking Flags

(firefox50 affected, firefox51 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
Let's move other widgets to WidgetCache and use them in other widget code.
(Reporter)

Comment 1

2 years ago
Created attachment 8775293 [details] [diff] [review]
patch

There's a patch for it, Thanks!
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=87a0051627d8
Attachment #8775293 - Flags: review?(andrew)
Comment on attachment 8775293 [details] [diff] [review]
patch

Review of attachment 8775293 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, just one thing;

::: widget/gtk/WidgetStyleCache.cpp
@@ +542,5 @@
> +                                     GTK_STYLE_CLASS_PANE_SEPARATOR);
> +    case MOZ_GTK_SPLITTER_SEPARATOR_VERTICAL:
> +      // TODO - create from CSS node
> +      return GetWidgetStyleWithClass(MOZ_GTK_SPLITTER_VERTICAL,
> +                                     GTK_STYLE_CLASS_PANE_SEPARATOR);

Since "separator" is a proper subnode of "paned", can we get that subnode here instead with CreateChildCSSNode?
Attachment #8775293 - Flags: review?(andrew) → review+
(Reporter)

Comment 3

2 years ago
Created attachment 8775947 [details] [diff] [review]
patch for check-in

Thanks, there's the one with CreateChildCSSNode().
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b1451b337255
(Reporter)

Comment 4

2 years ago
Comment on attachment 8775947 [details] [diff] [review]
patch for check-in

btw. It needs landed patch from Bug 1288413 before check-in.
(Reporter)

Updated

2 years ago
Keywords: checkin-needed

Comment 5

2 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/60a5e5073e1f
Move gHPanedWidget/gVPanedWidget to WidgetCache, r=acomminos
Keywords: checkin-needed

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/60a5e5073e1f
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.