[Static Analysis][Uninitialized scalar field] In constructor DispatchWheelInputOnControllerThread

RESOLVED FIXED in Firefox 50

Status

()

Core
Widget
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: andi, Assigned: andi)

Tracking

(Blocks: 1 bug, {coverity})

Trunk
mozilla50
coverity
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

(Whiteboard: CID 1364450)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
The Static Analysis tool Coverity detected that |mAPZResult| is not initialised in the constructor. But looking over the code i think we can remove this member variable and just use a local variable since it's not used in any other function nor it's passed as a reference nor pointer to DispatchWheelEventOnMainThread.
(Assignee)

Comment 1

2 years ago
Created attachment 8775156 [details]
Bug 1289792 - removed member variable mAPZResult and used a local one in Run().

Review commit: https://reviewboard.mozilla.org/r/67424/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67424/
Attachment #8775156 - Flags: review?(vladimir)

Comment 3

2 years ago
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/99cc6fc1ed3f
removed member variable mAPZResult and used a local one in Run(). r=vlad

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/99cc6fc1ed3f
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.