1289796 - default ios version should be 5.0 instead of 4.0 in release notes

Status: RESOLVED FIXED

(www.mozilla.org :: Release notes, defect)

Description

[Chris Ilias [:cilias]]

+++ This bug was initially created as a clone of Bug #1281648 +++

+++ This bug was initially created as a clone of Bug #1263445 +++

Well, the version number is still hardcoded on Bedrock:

https://github.com/mozilla/bedrock/blob/master/bedrock/settings/base.py#L1060

We should use ship-it now.

https://product-details.mozilla.org/mobile_versions.json
https://github.com/mozilla/ship-it/blob/master/kickoff/config.py

Comment 1

[Kohei Yoshino [:kohei]]

Attachment: pull request for bedrock

Comment 2

[Kohei Yoshino [:kohei]]

Attachment: pull request for ship-it

It's hardcoded anyway ;-)

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/3b8fef10e1b43893b711b409e5d35ca7576a4b62
Fix Bug 1289796 - default ios version should be 5.0 instead of 4.0 in release notes

https://github.com/mozilla/bedrock/commit/11014b1795006c0021e5b9dc52041abb26c04afa
Merge pull request #4249 from kyoshino/bug-1289796-ios-version

Fix Bug 1289796 - default ios version should be 5.0 instead of 4.0 in release notes

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on http://www-dev.allizom.org/firefox/ios/notes, which redirects to https://www-dev.allizom.org/en-US/firefox/ios/5.0/releasenotes/

I (or someone else, can) will verify on prod once it's pushed.

Comment 5

[Chris Ilias [:cilias]]

I noticed this still hasn't been pushed to prod. Are we waiting for a human to do something, or is it automated?

Comment 6

[Kohei Yoshino [:kohei]]

Mirroring to production requires a manual push. Since it's Friday, the earliest push will be next Monday.