Closed Bug 1289811 Opened 3 years ago Closed 3 years ago

nsIOutputStreamCallback should have a [function] attribute

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: jsnajdr, Assigned: jsnajdr)

Details

Attachments

(1 file, 1 obsolete file)

nsIInputStreamCallback has a [function] attribute, while nsOutputStreamCallback doesn't and needs to be implemented in JS as an object with onOutputStreamReady property.
Asking :ttaubert for review, who added the [function] attribute to nsIInputStreamCallback in bug 720697.
Attachment #8775476 - Flags: review?(ttaubert)
Comment on attachment 8775476 [details] [diff] [review]
nsIOutputStreamCallback should have a [function] attribute

Hmmm, I'm not the right person to review this. Nathan, maybe? :)
Attachment #8775476 - Flags: review?(ttaubert) → review?(nfroyd)
Attachment #8775476 - Flags: review?(nfroyd) → review+
Changed the reviewer in commit message.
Attachment #8775748 - Flags: review+
Attachment #8775476 - Attachment is obsolete: true
Assignee: nobody → jsnajdr
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab6dd1b9f840
Give nsIOutputStreamCallback a [function] attribute. r=nfroyd
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ab6dd1b9f840
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.