nsIOutputStreamCallback should have a [function] attribute

RESOLVED FIXED in Firefox 50

Status

()

Core
XPCOM
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jsnajdr, Assigned: jsnajdr)

Tracking

unspecified
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

a year ago
nsIInputStreamCallback has a [function] attribute, while nsOutputStreamCallback doesn't and needs to be implemented in JS as an object with onOutputStreamReady property.
(Assignee)

Comment 1

a year ago
Created attachment 8775476 [details] [diff] [review]
nsIOutputStreamCallback should have a [function] attribute

Asking :ttaubert for review, who added the [function] attribute to nsIInputStreamCallback in bug 720697.
Attachment #8775476 - Flags: review?(ttaubert)
Comment on attachment 8775476 [details] [diff] [review]
nsIOutputStreamCallback should have a [function] attribute

Hmmm, I'm not the right person to review this. Nathan, maybe? :)
Attachment #8775476 - Flags: review?(ttaubert) → review?(nfroyd)
Attachment #8775476 - Flags: review?(nfroyd) → review+
(Assignee)

Comment 3

a year ago
Created attachment 8775748 [details] [diff] [review]
nsIOutputStreamCallback should have a [function] attribute

Changed the reviewer in commit message.
Attachment #8775748 - Flags: review+
(Assignee)

Updated

a year ago
Attachment #8775476 - Attachment is obsolete: true
(Assignee)

Updated

a year ago
Assignee: nobody → jsnajdr
Keywords: checkin-needed

Comment 4

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab6dd1b9f840
Give nsIOutputStreamCallback a [function] attribute. r=nfroyd
Keywords: checkin-needed

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ab6dd1b9f840
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.