Closed
Bug 1289813
Opened 8 years ago
Closed 8 years ago
split out safe mode from FEATURE_FAILURE_WEBGL_DISABLED
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla50
People
(Reporter: BenWa, Assigned: BenWa)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
58 bytes,
text/x-review-board-request
|
jrmuizel
:
review+
gchang
:
approval-mozilla-aurora+
|
Details |
FEATURE_FAILURE_WEBGL_DISABLED is about 8% right now. We need to know how many are coming from safe mode.
|
Assignee | |
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/67430/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/67430/
Attachment #8775185 -
Flags: review?(jmuizelaar)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8775185 [details] Bug 1289813 - split out safe mode from FEATURE_FAILURE_WEBGL_DISABLED. https://reviewboard.mozilla.org/r/67430/#review64488
Attachment #8775185 -
Flags: review?(jmuizelaar) → review+
|
|
||
Comment 3•8 years ago
|
||
It's probably worth uplifting this.
|
||
Updated•8 years ago
|
Assignee: nobody → bgirard
|
|
Assignee | |
Comment 4•8 years ago
|
||
Comment on attachment 8775185 [details] Bug 1289813 - split out safe mode from FEATURE_FAILURE_WEBGL_DISABLED. Approval Request Comment [Feature/regressing bug #]: Not a regression [User impact if declined]: None, not a regression [Describe test coverage new/current, TreeHerder]: We're monitoring the data coming back manually. [Risks and why]: Effectively zero, we're checking the same code above and just sending a more specific string. [String/UUID change made/needed]: none
Attachment #8775185 -
Flags: approval-mozilla-aurora?
|
|
Assignee | |
Comment 5•8 years ago
|
||
Comment on attachment 8775185 [details] Bug 1289813 - split out safe mode from FEATURE_FAILURE_WEBGL_DISABLED. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/67430/diff/1-2/
|
|
Assignee | |
Comment 6•8 years ago
|
||
Rebased against another failureId change patch.
Pushed by b56girard@gmail.com: https://hg.mozilla.org/integration/autoland/rev/3252e497b111 split out safe mode from FEATURE_FAILURE_WEBGL_DISABLED. r=jrmuizel
|
||
Comment 8•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3252e497b111
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
|
||
Comment 9•8 years ago
|
||
Comment on attachment 8775185 [details] Bug 1289813 - split out safe mode from FEATURE_FAILURE_WEBGL_DISABLED. This patch is used to get data from safe mode. Take it in aurora.
Attachment #8775185 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
||
Updated•8 years ago
|
status-firefox49:
--- → affected
|
|
||
Comment 10•8 years ago
|
||
does not apply cleanly to aurora grafting 356945:3252e497b111 "Bug 1289813 - split out safe mode from FEATURE_FAILURE_WEBGL_DISABLED. r=jrmuizel" merging dom/canvas/WebGLContext.cpp warning: conflicts while merging dom/canvas/WebGLContext.cpp! (edit, then use 'hg resolve --mark') abort: unresolved conflicts, can't continue (use 'hg resolve' and 'hg graft --continue')
Flags: needinfo?(bgirard)
|
|
Assignee | |
Comment 11•8 years ago
|
||
I missed the merge, let's not uplift to beta.
Flags: needinfo?(bgirard)
|
|
Assignee | |
Updated•8 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•