1289818 - Investigate TriggeringPrincipal for simple window.open()

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[Christoph Kerschbaumer [:ckerschb]]

Similar to Bug 1289382, but only for simple window.open() cases.

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1289818_test_triggeringprincipal_simple_window_open.patch

Jonas, it seems a simple window.open() works as expected. I think it makes sense to have that testcase landed before investigating the more complicated case of a targeted window.open() within Bug 1289382.

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

Comment on attachment 8775220 [details] [diff] [review]
bug_1289818_test_triggeringprincipal_simple_window_open.patch

Olli, Jonas is too busy to review those changes before he leaves, any chance you wanna review those tests?

It seems a simple window.open() works as expected, but we should land that testcase to make sure we are not regressing it once we make more changes to docshell and it's triggeringPrincipal.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8775220 [details] [diff] [review]
bug_1289818_test_triggeringprincipal_simple_window_open.patch

I don't understand why loadingPrincipal is null, when our documentation clearly says it should never be null
http://searchfox.org/mozilla-central/rev/3df383b8552c1f8059f5c21258388ddb5a2f33d0/netwerk/base/nsILoadInfo.idl#188-190

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

ok, sicking explained in that other bug that we've quite radically changed the meaning of loadingPrincipal and it can now be null.
The documentation must be fixed.

Comment 5

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Olli Pettay [:smaug] from comment #4)
> ok, sicking explained in that other bug that we've quite radically changed
> the meaning of loadingPrincipal and it can now be null.
> The documentation must be fixed.

I filed bug 1291458 to update the documentation for LoadingPrincipal within nsILoadInfo.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5ea46f773afb
Test TriggeringPrincipal for a simple window.open(). r=smaug

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5ea46f773afb