Closed Bug 1289827 Opened 4 years ago Closed 4 years ago

Waiting in netmonitor -> timings isn't visible on dark theme

Categories

(DevTools :: Netmonitor, defect, P2, trivial)

48 Branch
defect

Tracking

(firefox47 unaffected, firefox48 wontfix, firefox49 verified, firefox50 verified)

VERIFIED FIXED
Firefox 50
Tracking Status
firefox47 --- unaffected
firefox48 --- wontfix
firefox49 --- verified
firefox50 --- verified

People

(Reporter: arni2033, Assigned: steveck)

References

Details

(Keywords: regression, Whiteboard: [good taipei bug][good first bug][lang=css])

Attachments

(2 files)

>>>   My Info:   Win7_64, Nightly 49, 32bit, ID 20160526082509
STR:
1. Open https://bugzilla.mozilla.org/
2. Open devtools -> netmonitor, reload tab
3. Click on any request in netmonitor
4. Select tab "timings" in sidebar

AR:  No blue rectangle after word "Waiting"
ER:  There should be a blue rectangle

This is regression from bug 1244054, because there's a typo "timig". This is how I found it:
http://hg.mozilla.org/mozilla-central/file/tip/devtools/client/themes/netmonitor.css
http://hg.mozilla.org/mozilla-central/log/tip/devtools/client/themes/netmonitor.css
http://hg.mozilla.org/mozilla-central/rev/f06ae0dbd3a5
https://bugzilla.mozilla.org/show_bug.cgi?id=1244054
Version: unspecified → 48 Branch
Whiteboard: [good taipei bug][good first bug][lang=css]
Priority: -- → P2
Just a small typo fixing.
Assignee: nobody → schung
Status: NEW → ASSIGNED
Comment on attachment 8775847 [details]
Bug 1289827 - Waiting in netmonitor -> timings isn't visible on dark theme.

https://reviewboard.mozilla.org/r/67898/#review64966

Thanks!
Attachment #8775847 - Flags: review?(ntim.bugs) → review+
Too late for 48 but happy to take a patch in 49
Keywords: checkin-needed
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/ae39b860cdd3
Waiting in netmonitor -> timings isn't visible on dark theme. r=ntim
Keywords: checkin-needed
Comment on attachment 8775847 [details]
Bug 1289827 - Waiting in netmonitor -> timings isn't visible on dark theme.

Approval Request Comment
[Feature/regressing bug #]: Firebug theme
[User impact if declined]: see attachment 8775230 [details]
[Describe test coverage new/current, TreeHerder]: on fx-team, soon on m-c
[Risks and why]: Low css typo fix
[String/UUID change made/needed]: none
Attachment #8775847 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/ae39b860cdd3
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
I've managed this issue on this bug in Nightly 49.0a1 (2016-05-26) ; (Build ID: 20160526030223) from Linux.

This Bug is now verified as fixed on Latest Firefox Nightly 50.0a1 (2016-07-30)

Build ID: 20160730030204
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0
OS: Linux 4.4.0-31-generic ; Ubuntu 16.04 (64 Bit)
QA Whiteboard: [bugday-20160727]
Comment on attachment 8775847 [details]
Bug 1289827 - Waiting in netmonitor -> timings isn't visible on dark theme.

This patch fixes a regression. Take it in aurora.
Attachment #8775847 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I have reproduced this Bug on Firefox Developer Edition 49.0a2 (2016-07-27) on Windows 10, 64 Bit!

The bug's fix is now verified on latest Firefox Developer Edition 50.0a2 

aurora 50.0a2:
Build ID 	20160813004002
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:50.0) Gecko/20100101 Firefox/50.0

[testday-20160812]
Status: RESOLVED → VERIFIED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.