Closed
Bug 1289857
Opened 8 years ago
Closed 8 years ago
build fails when disable-webrtc in mozconfig
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox50 fixed)
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: rforbes, Assigned: jib)
Details
Attachments
(2 files)
31:19.12 Creating library xul.lib and object xul.exp 31:19.12 31:19.12 LINK : warning LNK4199: /DELAYLOAD:dbghelp.dll ignored; no imports found from dbghelp.dll 31:19.12 31:19.12 LINK : warning LNK4199: /DELAYLOAD:PowrProf.dll ignored; no imports found from PowrProf.dll 31:19.12 31:19.12 LINK : warning LNK4199: /DELAYLOAD:rasapi32.dll ignored; no imports found from rasapi32.dll 31:19.12 31:19.12 LINK : warning LNK4199: /DELAYLOAD:rasdlg.dll ignored; no imports found from rasdlg.dll 31:19.12 31:19.12 Unified_cpp_dom_media2.obj : error LNK2019: unresolved external symbol "public: bool __thiscall mozilla::NormalizedConstraintSet::Range<bool>::Merge(class mozilla::NormalizedConstraintSet::Range<bool> const &)" (?Merge@?$Range@_N@NormalizedConstraintSet@mozilla@@QAE_NABV123@@Z) referenced in function "private: virtual bool __thiscall mozilla::NormalizedConstraintSet::Range<bool>::Merge(class mozilla::NormalizedConstraintSet::BaseRange const &)" (?Merge@?$Range@_N@NormalizedConstraintSet@mozilla@@EAE_NABVBaseRange@23@@Z) 31:19.12 31:19.12 Unified_cpp_dom_media2.obj : error LNK2001: unresolved external symbol "public: virtual void __thiscall mozilla::NormalizedConstraintSet::Range<bool>::FinalizeMerge(void)" (?FinalizeMerge@?$Range@_N@NormalizedConstraintSet@mozilla@@UAEXXZ) 31:19.12 31:19.12 Unified_cpp_dom_media2.obj : error LNK2019: unresolved external symbol "public: bool __thiscall mozilla::NormalizedConstraintSet::StringRange::Merge(struct mozilla::NormalizedConstraintSet::StringRange const &)" (?Merge@StringRange@NormalizedConstraintSet@mozilla@@QAE_NABU123@@Z) referenced in function "private: virtual bool __thiscall mozilla::NormalizedConstraintSet::StringRange::Merge(class mozilla::NormalizedConstraintSet::BaseRange const &)" (?Merge@StringRange@NormalizedConstraintSet@mozilla@@EAE_NABVBaseRange@23@@Z) 31:19.12 31:19.12 Unified_cpp_dom_media2.obj : error LNK2019: unresolved external symbol "public: __thiscall mozilla::NormalizedConstraints::NormalizedConstraints(struct mozilla::dom::MediaTrackConstraints const &,class nsTArray<class mozilla::NormalizedConstraintSet::BaseRange mozilla::NormalizedConstraintSet::*> *)" (??0NormalizedConstraints@mozilla@@QAE@ABUMediaTrackConstraints@dom@1@PAV?$nsTArray@PQNormalizedConstraintSet@mozilla@@VBaseRange@12@@@@Z) referenced in function "public: static char const * __cdecl mozilla::MediaConstraintsHelper::FindBadConstraint<class mozilla::AudioDevice>(struct mozilla::NormalizedConstraints const &,class nsTArray<class RefPtr<class mozilla::AudioDevice> > &)" (??$FindBadConstraint@VAudioDevice@mozilla@@@MediaConstraintsHelper@mozilla@@SAPBDABUNormalizedConstraints@1@AAV?$nsTArray@V?$RefPtr@VAudioDevice@mozilla@@@@@@@Z) 31:19.12 31:19.12 xul.dll : fatal error LNK1120: 4 unresolved externals 31:19.12 31:19.12 c:/Users/rforbes/src/mozilla-central/config/rules.mk:817: recipe for target 'xul.dll' failed 31:19.12 mozmake.EXE[5]: *** [xul.dll] Error 1120 31:19.12 c:/Users/rforbes/src/mozilla-central/config/recurse.mk:71: recipe for target 'toolkit/library/target' failed 31:19.12 mozmake.EXE[4]: *** [toolkit/library/target] Error 2 31:19.12 c:/Users/rforbes/src/mozilla-central/config/recurse.mk:32: recipe for target 'compile' failed 31:19.12 mozmake.EXE[3]: *** [compile] Error 2 31:19.12 c:/Users/rforbes/src/mozilla-central/config/rules.mk:540: recipe for target 'default' failed 31:19.12 mozmake.EXE[2]: *** [default] Error 2 31:19.12 c:/Users/rforbes/src/mozilla-central/client.mk:413: recipe for target 'realbuild' failed 31:19.12 mozmake.EXE[1]: *** [realbuild] Error 2 31:19.12 client.mk:168: recipe for target 'build' failed 31:19.12 mozmake.EXE: *** [build] Error 2 31:19.17 131 compiler warnings present. 2 rforbes@rforbes-worklap ~/src/mozilla-central $
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/67784/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/67784/
Attachment #8775615 -
Flags: review?(mfroman)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → jib
Reporter | ||
Comment 2•8 years ago
|
||
this seems to have done the trick. I am able to build again. thanks!
Comment 3•8 years ago
|
||
Comment on attachment 8775615 [details] Bug 1289857 - Fix MediaTrackConstraints.cpp to compile with --disable-webrtc again. https://reviewboard.mozilla.org/r/67784/#review64876 Looks good to me.
Attachment #8775615 -
Flags: review?(mfroman) → review+
Pushed by jbruaroey@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4c84eea22241 Fix MediaTrackConstraints.cpp to compile with --disable-webrtc again. r=mjf
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4c84eea22241
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•