1289909 - Prototype scroll-driven animations driven by the compositor

Status: RESOLVED DUPLICATE of bug 1321428

(Core :: Graphics: Layers, defect)

Description

[Botond Ballo [:botond]]

We are working on prototyping scroll-driven animations (bug 1281348) in Firefox.

Part of this work will be to prototype OMTA support for such animations, that is, having them driven by the compositor thread.

Comment 1

[Botond Ballo [:botond]]

Attachment: Rename Orientation to ScrollDirection to avoid a naming conflict

Review commit: https://reviewboard.mozilla.org/r/69134/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69134/

Comment 2

[Botond Ballo [:botond]]

Attachment: Represent scroll timeline information in the Layers API

Review commit: https://reviewboard.mozilla.org/r/69136/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69136/

Comment 3

[Botond Ballo [:botond]]

Attachment: Populate scroll timeline information in FrameLayerBuilder

Review commit: https://reviewboard.mozilla.org/r/69138/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69138/

Comment 4

[Botond Ballo [:botond]]

Attachment: Handle scroll-driven animations in AsyncCompositionManager

Review commit: https://reviewboard.mozilla.org/r/69140/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69140/

Comment 5

[Botond Ballo [:botond]]

^ These are WIP patches, they do not work yet.

These patches depend on the patches in bug 1289915.

Comment 6

[Botond Ballo [:botond]]

Attachment: Show the number of OMT animations on a layer in the layer dump

Review commit: https://reviewboard.mozilla.org/r/69726/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69726/

Comment 7

[Botond Ballo [:botond]]

Attachment: Expose APZ's copy of FrameMetrics to AsyncCompositionManager

Review commit: https://reviewboard.mozilla.org/r/69728/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69728/

Comment 8

[Botond Ballo [:botond]]

Attachment: Add a couple of helper functions to AsyncCompositionManager

Review commit: https://reviewboard.mozilla.org/r/69730/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69730/

Comment 9

[Botond Ballo [:botond]]

Attachment: Enable OMTA for scroll timelines

Review commit: https://reviewboard.mozilla.org/r/69732/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69732/

Comment 10

[Botond Ballo [:botond]]

Comment on attachment 8777612 [details]
Rename Orientation to ScrollDirection to avoid a naming conflict

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69134/diff/1-2/

Comment 11

[Botond Ballo [:botond]]

Comment on attachment 8777613 [details]
Represent scroll timeline information in the Layers API

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69136/diff/1-2/

Comment 12

[Botond Ballo [:botond]]

Comment on attachment 8777614 [details]
Populate scroll timeline information in FrameLayerBuilder

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69138/diff/1-2/

Comment 13

[Botond Ballo [:botond]]

Comment on attachment 8777615 [details]
Handle scroll-driven animations in AsyncCompositionManager

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69140/diff/1-2/

Comment 14

[Botond Ballo [:botond]]

The updated patch series implements basic OMTA support for scroll-driven animations. With these patches applied (on top of the patches in bug 1289915), scrolling the example at [1] results in the compositor driving the animation.

Obviously, a lot more work will need to be done to handle various edge cases and additional features of scroll timelines (for which main-thread support needs to be implemented as well), but this is a start / proof-of-concept.

[1] https://people.mozilla.org/~bballo/scroll-driven-animations/test.html

Comment 15

[Botond Ballo [:botond]]

For anyone following this bug: ongoing work on the scroll-driven animations in prototype is happening in a user repo:

  http://hg.mozilla.org/users/bballo_mozilla.com/scroll-driven-animations/

Examples of what works can be found here (needs to be viewed with a build of the above user repo):

  https://theres-waldo.github.io/scroll-driven-animations/

And we are using this issue tracker to track issues in the prototype implementation:

  https://github.com/theres-waldo/scroll-driven-animations/issues

Comment 16

[Botond Ballo [:botond]]

Oh, and a work-in-progress specification can be found here:

  https://birtles.github.io/scroll-animations

Comment 17

[Botond Ballo [:botond]]

The changes in these patches will land as part of bug 1321428.