Closed Bug 1289909 Opened 4 years ago Closed 3 years ago

Prototype scroll-driven animations driven by the compositor

Categories

(Core :: Graphics: Layers, defect)

defect
Not set

Tracking

()

RESOLVED DUPLICATE of bug 1321428
Tracking Status
firefox50 --- affected

People

(Reporter: botond, Assigned: botond)

References

(Blocks 2 open bugs)

Details

Attachments

(8 files)

We are working on prototyping scroll-driven animations (bug 1281348) in Firefox.

Part of this work will be to prototype OMTA support for such animations, that is, having them driven by the compositor thread.
^ These are WIP patches, they do not work yet.

These patches depend on the patches in bug 1289915.
Review commit: https://reviewboard.mozilla.org/r/69726/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69726/
Attachment #8777615 - Attachment description: [WIP] Handle scroll-driven animations in AsyncCompositionManager → Handle scroll-driven animations in AsyncCompositionManager
Comment on attachment 8777612 [details]
Rename Orientation to ScrollDirection to avoid a naming conflict

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69134/diff/1-2/
Comment on attachment 8777613 [details]
Represent scroll timeline information in the Layers API

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69136/diff/1-2/
Comment on attachment 8777614 [details]
Populate scroll timeline information in FrameLayerBuilder

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69138/diff/1-2/
Comment on attachment 8777615 [details]
Handle scroll-driven animations in AsyncCompositionManager

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69140/diff/1-2/
The updated patch series implements basic OMTA support for scroll-driven animations. With these patches applied (on top of the patches in bug 1289915), scrolling the example at [1] results in the compositor driving the animation.

Obviously, a lot more work will need to be done to handle various edge cases and additional features of scroll timelines (for which main-thread support needs to be implemented as well), but this is a start / proof-of-concept.

[1] https://people.mozilla.org/~bballo/scroll-driven-animations/test.html
For anyone following this bug: ongoing work on the scroll-driven animations in prototype is happening in a user repo:

  http://hg.mozilla.org/users/bballo_mozilla.com/scroll-driven-animations/

Examples of what works can be found here (needs to be viewed with a build of the above user repo):

  https://theres-waldo.github.io/scroll-driven-animations/

And we are using this issue tracker to track issues in the prototype implementation:

  https://github.com/theres-waldo/scroll-driven-animations/issues
Oh, and a work-in-progress specification can be found here:

  https://birtles.github.io/scroll-animations
The changes in these patches will land as part of bug 1321428.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1321428
You need to log in before you can comment on or make changes to this bug.