If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

WasmTlsReg introduction breaks the "none" build because it is not defined on the "none" platform

RESOLVED FIXED in Firefox 50

Status

()

Core
JavaScript Engine: JIT
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: lth, Unassigned)

Tracking

unspecified
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

a year ago
In file included from /Users/lhansen/moz/mozilla-wasm/js/src/build-none/js/src/Unified_cpp_js_src0.cpp:11:
/Users/lhansen/moz/mozilla-wasm/js/src/asmjs/WasmBaselineCompile.cpp:1796:25: error: use of undeclared identifier 'WasmTlsReg'
        storeToFramePtr(WasmTlsReg, localInfo_[tlsSlot_].offs());
                        ^
/Users/lhansen/moz/mozilla-wasm/js/src/asmjs/WasmBaselineCompile.cpp:1832:32: error: use of undeclared identifier 'WasmTlsReg'
                       Address(WasmTlsReg, offsetof(wasm::TlsData, stackLimit)),
                               ^
/Users/lhansen/moz/mozilla-wasm/js/src/asmjs/WasmBaselineCompile.cpp:1848:26: error: use of undeclared identifier 'WasmTlsReg'
        loadFromFramePtr(WasmTlsReg, frameOffsetFromSlot(tlsSlot_, MIRType::Pointer));
                         ^
/Users/lhansen/moz/mozilla-wasm/js/src/asmjs/WasmBaselineCompile.cpp:5057:22: error: use of undeclared identifier 'WasmTlsReg'
    loadFromFramePtr(WasmTlsReg, frameOffsetFromSlot(tlsSlot_, MIRType::Pointer));
(Reporter)

Comment 1

a year ago
Also, as expected:

/Users/lhansen/moz/mozilla-wasm/js/src/jit/shared/LIR-shared.h:8184:43: error: use of undeclared identifier 'WasmTlsReg'
        if (reg.isFloat() || reg.gpr() != WasmTlsReg)
                                          ^
Created attachment 8775459 [details]
Bug 1289911: Add WasmTlsReg in none/ platform;

Review commit: https://reviewboard.mozilla.org/r/67642/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67642/
Attachment #8775459 - Flags: review?(jolesen)
(Reporter)

Comment 3

a year ago
https://reviewboard.mozilla.org/r/67640/#review64798

Thanks!
(Reporter)

Comment 4

a year ago
Comment on attachment 8775459 [details]
Bug 1289911: Add WasmTlsReg in none/ platform;

Ship it!
Attachment #8775459 - Flags: review?(jolesen) → review+

Comment 5

a year ago
Pushed by bbouvier@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/182cfbd9715f
Add WasmTlsReg in none/ platform; r=lth

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/182cfbd9715f
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.