Closed Bug 1289911 Opened 3 years ago Closed 3 years ago

WasmTlsReg introduction breaks the "none" build because it is not defined on the "none" platform

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: lth, Unassigned)

Details

Attachments

(1 file)

In file included from /Users/lhansen/moz/mozilla-wasm/js/src/build-none/js/src/Unified_cpp_js_src0.cpp:11:
/Users/lhansen/moz/mozilla-wasm/js/src/asmjs/WasmBaselineCompile.cpp:1796:25: error: use of undeclared identifier 'WasmTlsReg'
        storeToFramePtr(WasmTlsReg, localInfo_[tlsSlot_].offs());
                        ^
/Users/lhansen/moz/mozilla-wasm/js/src/asmjs/WasmBaselineCompile.cpp:1832:32: error: use of undeclared identifier 'WasmTlsReg'
                       Address(WasmTlsReg, offsetof(wasm::TlsData, stackLimit)),
                               ^
/Users/lhansen/moz/mozilla-wasm/js/src/asmjs/WasmBaselineCompile.cpp:1848:26: error: use of undeclared identifier 'WasmTlsReg'
        loadFromFramePtr(WasmTlsReg, frameOffsetFromSlot(tlsSlot_, MIRType::Pointer));
                         ^
/Users/lhansen/moz/mozilla-wasm/js/src/asmjs/WasmBaselineCompile.cpp:5057:22: error: use of undeclared identifier 'WasmTlsReg'
    loadFromFramePtr(WasmTlsReg, frameOffsetFromSlot(tlsSlot_, MIRType::Pointer));
Also, as expected:

/Users/lhansen/moz/mozilla-wasm/js/src/jit/shared/LIR-shared.h:8184:43: error: use of undeclared identifier 'WasmTlsReg'
        if (reg.isFloat() || reg.gpr() != WasmTlsReg)
                                          ^
Comment on attachment 8775459 [details]
Bug 1289911: Add WasmTlsReg in none/ platform;

Ship it!
Attachment #8775459 - Flags: review?(jolesen) → review+
Pushed by bbouvier@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/182cfbd9715f
Add WasmTlsReg in none/ platform; r=lth
https://hg.mozilla.org/mozilla-central/rev/182cfbd9715f
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.