1289911 - WasmTlsReg introduction breaks the "none" build because it is not defined on the "none" platform

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Lars T Hansen [:lth]]

In file included from /Users/lhansen/moz/mozilla-wasm/js/src/build-none/js/src/Unified_cpp_js_src0.cpp:11:
/Users/lhansen/moz/mozilla-wasm/js/src/asmjs/WasmBaselineCompile.cpp:1796:25: error: use of undeclared identifier 'WasmTlsReg'
        storeToFramePtr(WasmTlsReg, localInfo_[tlsSlot_].offs());
                        ^
/Users/lhansen/moz/mozilla-wasm/js/src/asmjs/WasmBaselineCompile.cpp:1832:32: error: use of undeclared identifier 'WasmTlsReg'
                       Address(WasmTlsReg, offsetof(wasm::TlsData, stackLimit)),
                               ^
/Users/lhansen/moz/mozilla-wasm/js/src/asmjs/WasmBaselineCompile.cpp:1848:26: error: use of undeclared identifier 'WasmTlsReg'
        loadFromFramePtr(WasmTlsReg, frameOffsetFromSlot(tlsSlot_, MIRType::Pointer));
                         ^
/Users/lhansen/moz/mozilla-wasm/js/src/asmjs/WasmBaselineCompile.cpp:5057:22: error: use of undeclared identifier 'WasmTlsReg'
    loadFromFramePtr(WasmTlsReg, frameOffsetFromSlot(tlsSlot_, MIRType::Pointer));

Comment 1

[Lars T Hansen [:lth]]

Also, as expected:

/Users/lhansen/moz/mozilla-wasm/js/src/jit/shared/LIR-shared.h:8184:43: error: use of undeclared identifier 'WasmTlsReg'
        if (reg.isFloat() || reg.gpr() != WasmTlsReg)
                                          ^

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Bug 1289911: Add WasmTlsReg in none/ platform;

Review commit: https://reviewboard.mozilla.org/r/67642/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67642/

Comment 3

[Lars T Hansen [:lth]]

https://reviewboard.mozilla.org/r/67640/#review64798

Thanks!

Comment 4

[Lars T Hansen [:lth]]

Comment on attachment 8775459 [details]
Bug 1289911: Add WasmTlsReg in none/ platform;

Ship it!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/182cfbd9715f
Add WasmTlsReg in none/ platform; r=lth

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/182cfbd9715f