Closed
Bug 1289923
Opened 7 years ago
Closed 7 years ago
Fix the minor errors found while writing test262 tests for DateTimeFormat.prototype.formatToParts
Categories
(Core :: JavaScript: Internationalization API, defect)
Core
JavaScript: Internationalization API
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: zbraniecki, Assigned: zbraniecki)
Details
Attachments
(1 file, 1 obsolete file)
876 bytes,
patch
|
zbraniecki
:
review+
|
Details | Diff | Splinter Review |
Currently I found one - the name of the function is wrong, but I may find more over the next day or two.
Assignee | ||
Comment 1•7 years ago
|
||
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•7 years ago
|
||
Comment on attachment 8775340 [details] [diff] [review] patch v1 Happy to say that there was only one tests262 error found! :) :waldo, can you review?
Attachment #8775340 -
Flags: review?(jwalden+bmo)
Comment 3•7 years ago
|
||
Comment on attachment 8775340 [details] [diff] [review] patch v1 Review of attachment 8775340 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/builtin/Intl.cpp @@ +1794,5 @@ > RootedValue ftp(cx); > + RootedAtom formatToPartsAtom(cx, cx->names().formatToParts); > + if (!GlobalObject::getSelfHostedFunction(cx, cx->global(), > + cx->names().DateTimeFormatFormatToParts, > + formatToPartsAtom, Have HandlePropertyName name = cx->names().formatToParts; and then pass name for this second argument.
Attachment #8775340 -
Flags: review?(jwalden+bmo) → review+
Assignee | ||
Comment 4•7 years ago
|
||
Carrying over r+ with addressed feedback.
Attachment #8775340 -
Attachment is obsolete: true
Attachment #8775804 -
Flags: review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 5•7 years ago
|
||
In the future, please ensure that the patches you request checkin on have the proper metadata needed for committing. https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Flags: needinfo?(gandalf)
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/23fd4759f733 Fix the minor errors found while writing test262 tests for DateTimeFormat.prototype.formatToParts. r=Waldo
Keywords: checkin-needed
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/23fd4759f733
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•