1289923 - Fix the minor errors found while writing test262 tests for DateTimeFormat.prototype.formatToParts

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

Currently I found one - the name of the function is wrong, but I may find more over the next day or two.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch v1

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8775340 [details] [diff] [review]
patch v1

Happy to say that there was only one tests262 error found! :)

:waldo, can you review?

Comment 3

[Jeff Walden [:Waldo]]

Comment on attachment 8775340 [details] [diff] [review]
patch v1

Review of attachment 8775340 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/builtin/Intl.cpp
@@ +1794,5 @@
>          RootedValue ftp(cx);
> +        RootedAtom formatToPartsAtom(cx, cx->names().formatToParts);
> +        if (!GlobalObject::getSelfHostedFunction(cx, cx->global(),
> +                    cx->names().DateTimeFormatFormatToParts,
> +                    formatToPartsAtom,

Have

HandlePropertyName name = cx->names().formatToParts;

and then pass name for this second argument.

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch v2

Carrying over r+ with addressed feedback.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

In the future, please ensure that the patches you request checkin on have the proper metadata needed for committing.
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/23fd4759f733
Fix the minor errors found while writing test262 tests for DateTimeFormat.prototype.formatToParts. r=Waldo

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

Will do! Sorry for that.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/23fd4759f733