Fix the minor errors found while writing test262 tests for DateTimeFormat.prototype.formatToParts

RESOLVED FIXED in Firefox 50

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: gandalf, Assigned: gandalf)

Tracking

unspecified
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
Currently I found one - the name of the function is wrong, but I may find more over the next day or two.
(Assignee)

Comment 1

2 years ago
Created attachment 8775340 [details] [diff] [review]
patch v1
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
(Assignee)

Comment 2

2 years ago
Comment on attachment 8775340 [details] [diff] [review]
patch v1

Happy to say that there was only one tests262 error found! :)

:waldo, can you review?
Attachment #8775340 - Flags: review?(jwalden+bmo)

Comment 3

2 years ago
Comment on attachment 8775340 [details] [diff] [review]
patch v1

Review of attachment 8775340 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/builtin/Intl.cpp
@@ +1794,5 @@
>          RootedValue ftp(cx);
> +        RootedAtom formatToPartsAtom(cx, cx->names().formatToParts);
> +        if (!GlobalObject::getSelfHostedFunction(cx, cx->global(),
> +                    cx->names().DateTimeFormatFormatToParts,
> +                    formatToPartsAtom,

Have

HandlePropertyName name = cx->names().formatToParts;

and then pass name for this second argument.
Attachment #8775340 - Flags: review?(jwalden+bmo) → review+
(Assignee)

Comment 4

2 years ago
Created attachment 8775804 [details] [diff] [review]
patch v2

Carrying over r+ with addressed feedback.
Attachment #8775340 - Attachment is obsolete: true
Attachment #8775804 - Flags: review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
In the future, please ensure that the patches you request checkin on have the proper metadata needed for committing.
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Flags: needinfo?(gandalf)

Comment 6

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/23fd4759f733
Fix the minor errors found while writing test262 tests for DateTimeFormat.prototype.formatToParts. r=Waldo
Keywords: checkin-needed
(Assignee)

Comment 7

2 years ago
Will do! Sorry for that.
Flags: needinfo?(gandalf)

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/23fd4759f733
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.