Closed Bug 1289923 Opened 7 years ago Closed 7 years ago

Fix the minor errors found while writing test262 tests for DateTimeFormat.prototype.formatToParts

Categories

(Core :: JavaScript: Internationalization API, defect)

Product:
Core
Component:
JavaScript: Internationalization API
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: zbraniecki, Assigned: zbraniecki)

Details

Attachments

(1 file, 1 obsolete file)

patch v2
876 bytes, patch
zbraniecki
: review+
Details | Diff | Splinter Review 
Currently I found one - the name of the function is wrong, but I may find more over the next day or two.
Attached patch patch v1 (obsolete) — — Splinter Review 
Assignee: nobody → gandalf
Status: NEW → ASSIGNED

    
    

    
  
Comment on attachment 8775340 [details] [diff] [review]
patch v1

Happy to say that there was only one tests262 error found! :)

:waldo, can you review?

        Attachment #8775340 -
        Flags: review?(jwalden+bmo)

    
    

    
  
Comment on attachment 8775340 [details] [diff] [review]
patch v1

Review of attachment 8775340 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/builtin/Intl.cpp
@@ +1794,5 @@
>          RootedValue ftp(cx);
> +        RootedAtom formatToPartsAtom(cx, cx->names().formatToParts);
> +        if (!GlobalObject::getSelfHostedFunction(cx, cx->global(),
> +                    cx->names().DateTimeFormatFormatToParts,
> +                    formatToPartsAtom,

Have

HandlePropertyName name = cx->names().formatToParts;

and then pass name for this second argument.

        Attachment #8775340 -
        Flags: review?(jwalden+bmo) → review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch v2
        — 
          — Splinter Review
      

    


  
Carrying over r+ with addressed feedback.

        Attachment #8775340 -
        Attachment is obsolete: true

        Attachment #8775804 -
        Flags: review+

    
    

    
  
In the future, please ensure that the patches you request checkin on have the proper metadata needed for committing.
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Flags: needinfo?(gandalf)

    
    

    
  
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/23fd4759f733
Fix the minor errors found while writing test262 tests for DateTimeFormat.prototype.formatToParts. r=Waldo
Keywords: checkin-needed

    
    

    
  
Will do! Sorry for that.
Flags: needinfo?(gandalf)

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/23fd4759f733
Status: ASSIGNED → RESOLVED
Closed: 7 years ago

          status-firefox50:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50

          You need to log in
          before you can comment on or make changes to this bug.