1289934 - Minor Intl code-fixes

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, defect)

Description

[Jeff Walden [:Waldo]]

Some little things noticed looking at the code with gandalf today.  Shouldn't require any deep ICU knowledge to understand.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Simplify ScopedICUObject to store deleter function as a template parameter, not as a runtime variable

First up, convert a runtime deleter-function into a compile-time template parameter.

We could also use UniquePtr here, but UniquePtr also requires a deleter function be a runtime-provided thing, like the existing class here does.

Comment 2

[Jeff Walden [:Waldo]]

Attachment: Close a UCalendar* if ucal_getType fails, and don't assume ucal_getType's return value outlives the UCalendar* it was gotten from

It happens that both these issues are only theoretical.  ucal_getType fails only if ucal_open failed, right now, in our in-tree ICU.  And ucal_getType only returns statically-allocated strings, in in-tree ICU.  But better to eliminate risk that this could change in the future.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c39c56bc1833
Simplify ScopedICUObject to store deleter function as a template parameter, not as a runtime variable.  r=sfink
https://hg.mozilla.org/integration/mozilla-inbound/rev/2251dbd1b3c8
Implement more-correct error handling if ucal_getType fails.  (It can't with current ICU, at least our in-tree copy.  But best be safe for the future.)  Also don't assume ucal_getType's return value on success outlives the corresponding UCalendar*.  (Again, no problem with current ICU, still worth fixing.)  r=sfink

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c39c56bc1833
https://hg.mozilla.org/mozilla-central/rev/2251dbd1b3c8