Closed
Bug 1289946
Opened 9 years ago
Closed 9 years ago
Building with mingw-gcc fails with EnumStringComparisonError
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox51 fixed)
RESOLVED
FIXED
mozilla51
Tracking | Status | |
---|---|---|
firefox51 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
Fun problem: the test in get_compiler_info returns that KERNEL is 1 when the compiler is mingw-gcc. The reason is that the preprocessed file contains something like "%KERNEL WINNT", which is interpreted as meaning KERNEL is WINNT. But with mingw-gcc, WINNT is #define'd, so this ends up being interpreted as "%KERNEL 1"
Comment hidden (mozreview-request) |
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → mh+mozilla
Comment 2•9 years ago
|
||
mozreview-review |
Comment on attachment 8789082 [details]
Bug 1289946 - Work around preprocessor default defines in get_compiler_info().
https://reviewboard.mozilla.org/r/77334/#review76312
LGTM
Attachment #8789082 -
Flags: review+
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/43217bdb842a
Work around preprocessor default defines in get_compiler_info(). r=gps
Comment 4•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Updated•9 years ago
|
Attachment #8789082 -
Flags: review?(cmanchester)
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•