58 bytes, text/x-review-board-request
Fun problem: the test in get_compiler_info returns that KERNEL is 1 when the compiler is mingw-gcc. The reason is that the preprocessed file contains something like "%KERNEL WINNT", which is interpreted as meaning KERNEL is WINNT. But with mingw-gcc, WINNT is #define'd, so this ends up being interpreted as "%KERNEL 1"
Comment on attachment 8789082 [details] Bug 1289946 - Work around preprocessor default defines in get_compiler_info(). https://reviewboard.mozilla.org/r/77334/#review76312 LGTM
Attachment #8789082 - Flags: review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/43217bdb842a Work around preprocessor default defines in get_compiler_info(). r=gps
Attachment #8789082 - Flags: review?(cmanchester)
You need to log in before you can comment on or make changes to this bug.