Closed Bug 1289946 Opened 4 years ago Closed 4 years ago

Building with mingw-gcc fails with EnumStringComparisonError

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox51 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla51
Tracking Flags:
Tracking Status
firefox51 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

Bug 1289946 - Work around preprocessor default defines in get_compiler_info().
58 bytes, text/x-review-board-request
gps
: review+
Details 
Fun problem: the test in get_compiler_info returns that KERNEL is 1 when the compiler is mingw-gcc. The reason is that the preprocessed file contains something like "%KERNEL WINNT", which is interpreted as meaning KERNEL is WINNT. But with mingw-gcc, WINNT is #define'd, so this ends up being interpreted as "%KERNEL 1"
Assignee: nobody → mh+mozilla
Comment on attachment 8789082 [details]
Bug 1289946 - Work around preprocessor default defines in get_compiler_info().

https://reviewboard.mozilla.org/r/77334/#review76312

LGTM
Attachment #8789082 - Flags: review+
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/43217bdb842a
Work around preprocessor default defines in get_compiler_info(). r=gps
https://hg.mozilla.org/mozilla-central/rev/43217bdb842a
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.