1289946 - Building with mingw-gcc fails with EnumStringComparisonError

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Fun problem: the test in get_compiler_info returns that KERNEL is 1 when the compiler is mingw-gcc. The reason is that the preprocessed file contains something like "%KERNEL WINNT", which is interpreted as meaning KERNEL is WINNT. But with mingw-gcc, WINNT is #define'd, so this ends up being interpreted as "%KERNEL 1"

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1289946 - Work around preprocessor default defines in get_compiler_info().

Some compilers on some platforms by default #define some of the values
we're using in the source we use in get_compiler_info(). Namely,
mingw-gcc #defines WINNT by default, and the WINNT in the source is then
replaced by 1, breaking the check.

The C preprocessor, fortunately, doesn't expand macros inside C strings.
So instead of `%KERNEL WINNT`, we output `%KERNEL "WINNT"`, and strip
out the double quotes. For good measure, we do this for all values in
the source used in get_compiler_info().

Review commit: https://reviewboard.mozilla.org/r/77334/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77334/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8789082 [details]
Bug 1289946 - Work around preprocessor default defines in get_compiler_info().

https://reviewboard.mozilla.org/r/77334/#review76312

LGTM

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43217bdb842a
Work around preprocessor default defines in get_compiler_info(). r=gps

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/43217bdb842a