1289947 - Logins not saved on www.icloud.com

Status: NEW

(Toolkit :: Password Manager: Site Compatibility, defect, P3)

Description

[Matthew N. [:MattN]]

https://www.icloud.com/ uses an <iframe> for the login form and doesn't use a <form> inside of that but it also doesn't trigger capture from navigation (bug 1166947).

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Matt, any thoughts on if this is fixable.  I see at least one user trying to use FF57 running into this:

https://twitter.com/lorriemeyer/status/931623182691270656

Comment 2

[Matthew N. [:MattN]]

It probably is fixable but unfortunately password manager isn't being actively worked on now or H1 next year so unless that changes this is unlikely to get fixed any time soon.

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

The user actually reported to me its working on icloud now.  Maybe the service changed something.  I don't have an account so I can't easily test myself.

Comment 5

[laszlo.bialis]

https://mega.nz/ another site where the password manager fails to save the log in credentials. The save password pop up is not showing at all (tried on latest Nightly 65.0a1 20181203093109) whereas on Chrome there is no such issue.

Comment 6

[Matthew N. [:MattN]]

It looks like iCloud isn't using pushState/replaceState but is instead manipulating window.location.hash upon login and therefore aFlags & Ci.nsIWebProgressListener.LOCATION_CHANGE_SAME_DOCUMENT is 1 while aWebProgress.loadType & Ci.nsIDocShell.LOAD_CMD_PUSHSTATE is 0.

onLocationChange (LoginManagerContent.jsm#63)
hashDidChange (javascript-packed.js#903) => window.location.hash!=="#"+e&&(window.location.hash=e)
_notifyPropertyObservers (javascript-packed.js#73)
endPropertyChanges (javascript-packed.js#69)
clearHash (javascript-packed.js#902)
enterState (javascript-packed.js#958)
enterState (javascript-packed.js#440)
_enterState (javascript-packed.js#440)
_executeGotoStateActions (javascript-packed.js#439)
gotoState (javascript-packed.js#439)
_flushPendingStateTransition (javascript-packed.js#443)
_cleanupStateTransition (javascript-packed.js#440)
_executeGotoStateActions (javascript-packed.js#440)
gotoState (javascript-packed.js#439)
redirectToState (javascript-packed.js#909)
checkIfDefaultAppIsCreated (javascript-packed.js#908)
languageDidLoad (javascript-packed.js#908)
_invokeCallback (javascript-packed.js#272)
run (javascript-packed.js#122)
_invokeCallback (javascript-packed.js#272)
loadModule (javascript-packed.js#269)
userDidAuthenticate (javascript-packed.js#910)
authDidValidate (javascript-packed.js#816)
…

Comment 7

[Matthew N. [:MattN]]

(In reply to laszlo.bialis from comment #5)

https://mega.nz/ another site where the password manager fails to save the
log in credentials. The save password pop up is not showing at all (tried on
latest Nightly 65.0a1 20181203093109) whereas on Chrome there is no such
issue.

This seems to be working for me now with the latest code (possibly thanks to bug 1287202). Please file a new bug if it still doesn't work for you in tomorrow's Nightly build from https://nightly.mozilla.org/

Comment 8

[Sergey Galich [:serg]]

Moving to P3 as this is not happening in the next release cycle.