1289969 - Keyword search has inconsistent space encoding for bookmarks and search engines

Status: RESOLVED INACTIVE

(Firefox :: Address Bar, defect, P5)

Description

[fireattack [:fireattack]]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36

Steps to reproduce:

1. Set a keyword for certain search engine in preference.
2. Set a bookmark with keyword and term of %s (e.g. https://www.google.com/search?q=%s )

Use both to search a term with space (assuming the keywords are g and k respectively, search "g ab cd" and "k ab cd").





Actual results:

For search engine, it will replace space with "+";
For bookmark, it will replace space with "%20".


Expected results:

They should be consistent, I guess?

Comment 1

[Marcel Dejean]

Both behaviors could be considered normal. As far as I know, %20 always works, while + only works in the query part of a URL: http://stackoverflow.com/questions/1634271/url-encoding-the-space-character-or-20

So, either replace spaces with %20 or + dependent on which part %s appears in, or always use %20.

Comment 2

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.