Stylo enable/disable button is broken

RESOLVED FIXED

Status

()

Core
CSS Parsing and Computation
P3
normal
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: shinglyu, Assigned: shinglyu)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
When the browser.js code is called the first time, the XUL menulist stuff is not ready, so the `selectedItem` property is override by an int == 0. So afterwards, no matter which menu item we select, it will always use stylo. I have a patch for that.
(Assignee)

Comment 2

2 years ago
Created attachment 8775414 [details] [diff] [review]
0001-Bug-1289973-Fix-Stylo-UI-dropdown-list.-r-manisheart.patch

Manish, can you kindly review this for me?

If it's OK, can you help me push this to the stylo branch? Because I don't have push permission to it.
Attachment #8775414 - Flags: review?(manishearth)
(Assignee)

Updated

2 years ago
Blocks: 1243581
Assignee: nobody → slyu
Status: NEW → ASSIGNED
Comment on attachment 8775414 [details] [diff] [review]
0001-Bug-1289973-Fix-Stylo-UI-dropdown-list.-r-manisheart.patch

Review of attachment 8775414 [details] [diff] [review]:
-----------------------------------------------------------------

I can't review this. Not sure of the approach either.
Attachment #8775414 - Flags: review?(manishearth) → review?(cam)
Comment on attachment 8775414 [details] [diff] [review]
0001-Bug-1289973-Fix-Stylo-UI-dropdown-list.-r-manisheart.patch

Review of attachment 8775414 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, let's push this to servo/gecko-dev.
Attachment #8775414 - Flags: review?(cam) → review+
Priority: -- → P3
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.