Closed
Bug 1289973
Opened 8 years ago
Closed 7 years ago
Stylo enable/disable button is broken
Categories
(Core :: CSS Parsing and Computation, defect, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
People
(Reporter: shinglyu, Assigned: shinglyu)
References
Details
Attachments
(1 file)
|
869 bytes,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•8 years ago
|
||
When the browser.js code is called the first time, the XUL menulist stuff is not ready, so the `selectedItem` property is override by an int == 0. So afterwards, no matter which menu item we select, it will always use stylo. I have a patch for that.
|
|
Assignee | |
Comment 2•8 years ago
|
||
Manish, can you kindly review this for me? If it's OK, can you help me push this to the stylo branch? Because I don't have push permission to it.
Attachment #8775414 -
Flags: review?(manishearth)
|
||
Updated•8 years ago
|
Assignee: nobody → slyu
Status: NEW → ASSIGNED
|
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8775414 [details] [diff] [review] 0001-Bug-1289973-Fix-Stylo-UI-dropdown-list.-r-manisheart.patch Review of attachment 8775414 [details] [diff] [review]: ----------------------------------------------------------------- I can't review this. Not sure of the approach either.
Attachment #8775414 -
Flags: review?(manishearth) → review?(cam)
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8775414 [details] [diff] [review] 0001-Bug-1289973-Fix-Stylo-UI-dropdown-list.-r-manisheart.patch Review of attachment 8775414 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, let's push this to servo/gecko-dev.
Attachment #8775414 -
Flags: review?(cam) → review+
|
||
Updated•8 years ago
|
Priority: -- → P3
|
||
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•