1289993 - Disconnect seek requests when shutting down MediaDecoder

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

We don't want MediaDecoder::OnSeek{Resolved,Rejected} to be called after Shutdown().

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1289993. Part 1 - Disconnect seek requests when shutting down MediaDecoder.

Review commit: https://reviewboard.mozilla.org/r/68204/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68204/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1289993. Part 2 - Call DiscardOngoingSeekIfExists() in MediaOmxCommonDecoder::CallSeek() as we do in MediaDecoder::CallSeek().

Review commit: https://reviewboard.mozilla.org/r/68206/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68206/

Comment 3

[Tzuhao Kuo [:kaku]]

Comment on attachment 8776437 [details]
Bug 1289993. Part 1 - Disconnect seek requests when shutting down MediaDecoder.

https://reviewboard.mozilla.org/r/68204/#review65290

Comment 4

[Tzuhao Kuo [:kaku]]

Comment on attachment 8776438 [details]
Bug 1289993. Part 2 - Call DiscardOngoingSeekIfExists() in MediaOmxCommonDecoder::CallSeek() as we do in MediaDecoder::CallSeek().

https://reviewboard.mozilla.org/r/68206/#review65292

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5b6e50febc4
Part 1 - Disconnect seek requests when shutting down MediaDecoder. r=kaku
https://hg.mozilla.org/integration/autoland/rev/6c5e03c24321
Part 2 - Call DiscardOngoingSeekIfExists() in MediaOmxCommonDecoder::CallSeek() as we do in MediaDecoder::CallSeek(). r=kaku

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e5b6e50febc4
https://hg.mozilla.org/mozilla-central/rev/6c5e03c24321