If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Disconnect seek requests when shutting down MediaDecoder

RESOLVED FIXED in Firefox 51

Status

()

Core
Audio/Video: Playback
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

a year ago
We don't want MediaDecoder::OnSeek{Resolved,Rejected} to be called after Shutdown().
(Assignee)

Updated

a year ago
Assignee: nobody → jwwang
Blocks: 1289288
Priority: -- → P3
(Assignee)

Comment 1

a year ago
Created attachment 8776437 [details]
Bug 1289993. Part 1 - Disconnect seek requests when shutting down MediaDecoder.

Review commit: https://reviewboard.mozilla.org/r/68204/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68204/
Attachment #8776437 - Flags: review?(kaku)
Attachment #8776438 - Flags: review?(kaku)
(Assignee)

Comment 2

a year ago
Created attachment 8776438 [details]
Bug 1289993. Part 2 - Call DiscardOngoingSeekIfExists() in MediaOmxCommonDecoder::CallSeek() as we do in MediaDecoder::CallSeek().

Review commit: https://reviewboard.mozilla.org/r/68206/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68206/

Comment 3

a year ago
Comment on attachment 8776437 [details]
Bug 1289993. Part 1 - Disconnect seek requests when shutting down MediaDecoder.

https://reviewboard.mozilla.org/r/68204/#review65290
Attachment #8776437 - Flags: review?(kaku) → review+

Comment 4

a year ago
Comment on attachment 8776438 [details]
Bug 1289993. Part 2 - Call DiscardOngoingSeekIfExists() in MediaOmxCommonDecoder::CallSeek() as we do in MediaDecoder::CallSeek().

https://reviewboard.mozilla.org/r/68206/#review65292
Attachment #8776438 - Flags: review?(kaku) → review+
(Assignee)

Comment 5

a year ago
Thanks!

Comment 6

a year ago
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e5b6e50febc4
Part 1 - Disconnect seek requests when shutting down MediaDecoder. r=kaku
https://hg.mozilla.org/integration/autoland/rev/6c5e03c24321
Part 2 - Call DiscardOngoingSeekIfExists() in MediaOmxCommonDecoder::CallSeek() as we do in MediaDecoder::CallSeek(). r=kaku

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e5b6e50febc4
https://hg.mozilla.org/mozilla-central/rev/6c5e03c24321
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.