Closed Bug 129 Opened 26 years ago Closed 26 years ago

Missing variable initialisation in ns\lib\layout\layimage.c

Categories

(MozillaClassic Graveyard :: Layout, defect, P3)

Product:
MozillaClassic Graveyard
Version:
1998-03-31
Platform:
x86
Windows NT
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: ben, Assigned: nisheeth_mozilla)

Details

Created by Ben Laurie (ben@algroup.co.uk) on Thursday, April 9, 1998 10:57:38 AM PDT
Additional Details :
Although I haven''t actually seen this cause a problem, it
seems clearly wrong:

ns\lib\layout\layimage.c line 2861:

    LO_ImageStruct *lo_image;

should be:

    LO_ImageStruct *lo_image=NULL;
Updated by Wan-Teh Chang (wtc@netscape.com) on Friday, April 24, 1998 12:24:12 PM PDT
Additional Details :
Added the file name to "Summary Description".
Assigned bug to owner of the layout module,
David Williams <djw@netscape.com>.
Updated by Nisheeth Ranjan (nisheeth@netscape.com) on Sunday, April 26, 1998 6:37:29 PM PDT
Additional Details :
Hmm...  Wan-Teh's bug assignment to djw  didn't go through properly because the
assigned to field was still bugzilla@mozilla.org.

Anyway, am assigning the bug to myself...
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Component: HTML Dialogs → Layout
Resolution: --- → FIXED
A crash will occur trying to dereference a NULL lo_image any time
lo_ImageObserver() will be called without a "closure" parameter.  This does not
happen anywhere currently and that is why we do not see any problems.  Just
initializing lo_image to NULL is not going to fix this case because the switch
statement in lo_ImageObserver also contains lo_image dereferencing statements
that are not guarded by a NULL check for lo_image.

The patch that fixes the problem you caught has just been checked into the
mozilla tree.  I'll post the URL to it on this bug report.

Thanks a lot for your input and help!
The URL for the patch is

http://cvs-mirror.mozilla.org/webtools/bonsai/cvsview2.cgi?diff_mode=context&whi
tespace_mode=show&subdir=mozilla/lib/layout&command=DIFF_FRAMESET&file=layimage.
c&rev1=3.18&rev2=3.19&root=/cvsroot
Status: RESOLVED → VERIFIED
Old bug....old code base...marking Verified.
You need to log in before you can comment on or make changes to this bug.