1290020 - Blocked permission icons should not inherit the tooltip from the identity block.

Status: VERIFIED FIXED

(Firefox :: General, defect, P1)

Description

[Johann Hofmann [:johannh]]

Since that text doesn't make sense for these icons, e.g. "This site does not supply identity information". This is supposed to be fixed in Bug 1285212 by adding tooltips for blocked permission icons, but since these tooltips are not there yet we should add an empty placeholder instead.

Comment 1

[Johann Hofmann [:johannh]]

Attachment: Bug 1290020 - Add a temporary empty tooltiptext to blocked permission icons.

Review commit: https://reviewboard.mozilla.org/r/67660/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67660/

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 8775484 [details]
Bug 1290020 - Add a temporary empty tooltiptext to blocked permission icons.

https://reviewboard.mozilla.org/r/67660/#review64780

Thanks!

Comment 3

[Johann Hofmann [:johannh]]

https://hg.mozilla.org/integration/fx-team/rev/18f864f24423d9d726972bdd17e63959c574fcfd
Bug 1290020 - Add a temporary empty tooltiptext to blocked permission icons. r=florian

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/18f864f24423

Comment 5

[Paul Silaghi, QA [:pauly]]

The tooltip still shows up if hovering above the blocked permission: http://screencast.com/t/9qy02opsfTu

Comment 6

[Johann Hofmann [:johannh]]

Yeah, that happens with other icons if you hover over the identity block as well. It would probably help to move the hovertext from the identity block to affect only the lock icon and EV text. This is a really small detail, but we might want to open a general bug about the sometimes confusing hovertext of the identity block. (It's not a regression from this bug).

Comment 7

[Johann Hofmann [:johannh]]

Ok I'll make a bug for solving that.

Comment 8

[Paul Silaghi, QA [:pauly]]

Verified fixed FX 50.0a2 (2016-08-02) Win 7, Ubuntu 14.04, OS X 10.9.5