Blocked permission icons should not inherit the tooltip from the identity block.

VERIFIED FIXED in Firefox 50

Status

()

P1
normal
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: johannh, Assigned: johannh)

Tracking

Trunk
Firefox 50
Points:
---
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox50 verified)

Details

(Whiteboard: [fxprivacy])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Since that text doesn't make sense for these icons, e.g. "This site does not supply identity information". This is supposed to be fixed in Bug 1285212 by adding tooltips for blocked permission icons, but since these tooltips are not there yet we should add an empty placeholder instead.
(Assignee)

Updated

2 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

2 years ago
Created attachment 8775484 [details]
Bug 1290020 - Add a temporary empty tooltiptext to blocked permission icons.

Review commit: https://reviewboard.mozilla.org/r/67660/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67660/
Attachment #8775484 - Flags: review?(florian)
Comment on attachment 8775484 [details]
Bug 1290020 - Add a temporary empty tooltiptext to blocked permission icons.

https://reviewboard.mozilla.org/r/67660/#review64780

Thanks!
Attachment #8775484 - Flags: review?(florian) → review+
(Assignee)

Comment 3

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/18f864f24423d9d726972bdd17e63959c574fcfd
Bug 1290020 - Add a temporary empty tooltiptext to blocked permission icons. r=florian

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/18f864f24423
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50

Updated

2 years ago
Priority: -- → P1
Whiteboard: [fxprivacy] [triage] → [fxprivacy]

Updated

2 years ago
Flags: qe-verify+

Updated

2 years ago
Iteration: --- → 50.4 - Aug 1
The tooltip still shows up if hovering above the blocked permission: http://screencast.com/t/9qy02opsfTu
Flags: needinfo?(jhofmann)
(Assignee)

Comment 6

2 years ago
Yeah, that happens with other icons if you hover over the identity block as well. It would probably help to move the hovertext from the identity block to affect only the lock icon and EV text. This is a really small detail, but we might want to open a general bug about the sometimes confusing hovertext of the identity block. (It's not a regression from this bug).
Flags: needinfo?(jhofmann)
(Assignee)

Comment 7

2 years ago
Ok I'll make a bug for solving that.
Verified fixed FX 50.0a2 (2016-08-02) Win 7, Ubuntu 14.04, OS X 10.9.5
Status: RESOLVED → VERIFIED
status-firefox50: fixed → verified
You need to log in before you can comment on or make changes to this bug.