Closed Bug 1290020 Opened 3 years ago Closed 3 years ago

Blocked permission icons should not inherit the tooltip from the identity block.

Categories

(Firefox :: General, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 50
Iteration:
50.4 - Aug 1
Tracking Status
firefox50 --- verified

People

(Reporter: johannh, Assigned: johannh)

References

Details

(Whiteboard: [fxprivacy])

Attachments

(1 file)

Since that text doesn't make sense for these icons, e.g. "This site does not supply identity information". This is supposed to be fixed in Bug 1285212 by adding tooltips for blocked permission icons, but since these tooltips are not there yet we should add an empty placeholder instead.
Status: NEW → ASSIGNED
Comment on attachment 8775484 [details]
Bug 1290020 - Add a temporary empty tooltiptext to blocked permission icons.

https://reviewboard.mozilla.org/r/67660/#review64780

Thanks!
Attachment #8775484 - Flags: review?(florian) → review+
https://hg.mozilla.org/integration/fx-team/rev/18f864f24423d9d726972bdd17e63959c574fcfd
Bug 1290020 - Add a temporary empty tooltiptext to blocked permission icons. r=florian
https://hg.mozilla.org/mozilla-central/rev/18f864f24423
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Priority: -- → P1
Whiteboard: [fxprivacy] [triage] → [fxprivacy]
Flags: qe-verify+
Iteration: --- → 50.4 - Aug 1
The tooltip still shows up if hovering above the blocked permission: http://screencast.com/t/9qy02opsfTu
Flags: needinfo?(jhofmann)
Yeah, that happens with other icons if you hover over the identity block as well. It would probably help to move the hovertext from the identity block to affect only the lock icon and EV text. This is a really small detail, but we might want to open a general bug about the sometimes confusing hovertext of the identity block. (It's not a regression from this bug).
Flags: needinfo?(jhofmann)
Ok I'll make a bug for solving that.
Verified fixed FX 50.0a2 (2016-08-02) Win 7, Ubuntu 14.04, OS X 10.9.5
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.