Closed Bug 1290034 Opened 9 years ago Closed 9 years ago

Ensure nursery allocations are correctly aligned

Categories

(Core :: JavaScript: GC, defect)

Product:
Core
Component:
JavaScript: GC
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

bug1290034-check-nursery-alignment
1.91 KB, patch
terrence
: review+
Details | Diff | Splinter Review
We currently allow non-aligned allocations to be allocated from the nursery. This works but cases assertion failures when subsequently allocated objects are used, because their addresses are not correctly aligned.
Attachment #8775514 - Flags: review?(terrence)
Comment on attachment 8775514 [details] [diff] [review] bug1290034-check-nursery-alignment Review of attachment 8775514 [details] [diff] [review]: ----------------------------------------------------------------- Oh, good catch!
Attachment #8775514 - Flags: review?(terrence) → review+
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/721b016eecea Ensure nursery allocations are correctly aligned r=terrence
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3424ab3ae5f7 Ensure nursery allocations are correctly aligned r=terrence
https://hg.mozilla.org/mozilla-central/rev/3424ab3ae5f7
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Flags: needinfo?(jcoppeard)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: