Closed Bug 1290034 Opened 8 years ago Closed 8 years ago

Ensure nursery allocations are correctly aligned

Categories

(Core :: JavaScript: GC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

We currently allow non-aligned allocations to be allocated from the nursery.  This works but cases assertion failures when subsequently allocated objects are used, because their addresses are not correctly aligned.
Attachment #8775514 - Flags: review?(terrence)
Comment on attachment 8775514 [details] [diff] [review]
bug1290034-check-nursery-alignment

Review of attachment 8775514 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, good catch!
Attachment #8775514 - Flags: review?(terrence) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/721b016eecea
Ensure nursery allocations are correctly aligned r=terrence
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3424ab3ae5f7
Ensure nursery allocations are correctly aligned r=terrence
https://hg.mozilla.org/mozilla-central/rev/3424ab3ae5f7
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Flags: needinfo?(jcoppeard)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: