Closed
Bug 1290034
Opened 8 years ago
Closed 8 years ago
Ensure nursery allocations are correctly aligned
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
1.91 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
We currently allow non-aligned allocations to be allocated from the nursery. This works but cases assertion failures when subsequently allocated objects are used, because their addresses are not correctly aligned.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8775514 -
Flags: review?(terrence)
Comment 2•8 years ago
|
||
Comment on attachment 8775514 [details] [diff] [review] bug1290034-check-nursery-alignment Review of attachment 8775514 [details] [diff] [review]: ----------------------------------------------------------------- Oh, good catch!
Attachment #8775514 -
Flags: review?(terrence) → review+
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/721b016eecea Ensure nursery allocations are correctly aligned r=terrence
Comment 4•8 years ago
|
||
backed out for bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=32891639&repo=mozilla-inbound
Flags: needinfo?(jcoppeard)
Backout by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/18af1ad335a5 Backed out changeset 721b016eecea
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3424ab3ae5f7 Ensure nursery allocations are correctly aligned r=terrence
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3424ab3ae5f7
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(jcoppeard)
You need to log in
before you can comment on or make changes to this bug.
Description
•