Closed Bug 1290048 Opened 6 years ago Closed 6 years ago

Remove gtk_style_context_set_state/gtk_style_context_set_direction after ClaimStyleContext() call

Categories

(Core :: Widget: Gtk, defect)

Product:
Core
Component:
Widget: Gtk
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: stransky, Assigned: stransky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

patch
4.38 KB, patch
acomminos
: review+
Details | Diff | Splinter Review 
We should set state/direction as a part of ClaimStyleContext() call.
Blocks: gtk-3.20
No longer depends on: 1289763
Comment on attachment 8775537 [details] [diff] [review]
patch

Review of attachment 8775537 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8775537 - Flags: review?(andrew) → review+
Assignee: nobody → stransky
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5ad44f0d3ea4
Remove gtk_style_context_set_state/gtk_style_context_set_direction after ClaimStyleContext() call. r=acomminos
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5ad44f0d3ea4
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.